Closed eranl closed 10 months ago
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
d697143
) 61.35% compared to head (abbdf75
) 60.98%.:exclamation: Current head abbdf75 differs from pull request most recent head 950708f. Consider uploading reports for the commit 950708f to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/main/java/org/influxdb/dto/Point.java | 78.94% | 1 Missing and 3 partials :warning: |
...rc/main/java/org/influxdb/impl/InfluxDBMapper.java | 75.00% | 1 Missing and 1 partial :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Currently, there are two duplicate and somewhat divergent versions of this logic:
Point
doesn't check that values conform to field types and doesn't constrain allowed value typesInfluxDBMapper
uses atime
field rather than@TimeColumn
This change unifies the logic and takes the stricter path, which means that it may break existing code that relies on the current lenient logic.