Fix #828 "Context manager for InfluxDBClient not working correctly?"

influxdata / influxdb-python

Python client for InfluxDB

MIT License

1.7k stars 522 forks source link

Fix #828 "Context manager for InfluxDBClient not working correctly?" #831

Closed antimirov closed 3 years ago

antimirov commented 4 years ago

Fixed it by returning a client instance from enter

Contributor checklist

[X] Builds are passing
[] New tests have been added (for feature additions)

antimirov commented 4 years ago

Hm, the CI error seems to be unrelated to the commit. Can it be triggered to re-run?

vancromy commented 3 years ago

@aviau @sebito91 Would it be possible to review this. Doesn't look like a harmful change and as is although the documentation boasts the feature of context managers it is not right. As is today the client does not work as a context manager... Either fix the code or change the documentation :)

Ramshield commented 3 years ago

@aviau @sebito91 Anything I can do to help?

russorat commented 3 years ago

@antimirov just sign the CLA form and I will merge this. https://www.influxdata.com/legal/cla/#license-agreement

antimirov commented 3 years ago

@russorat I've signed it, please proceed