search

influxdata / influxdb-relay

Service to replicate InfluxDB data for high availability
MIT License
855 stars 350 forks source link

Add support for HTTP authentication #19

Closed weshmashian closed 8 years ago

weshmashian commented 8 years ago

Add in HTTP Auth support, configurable per backend.

This would resolve issue #13

gunnaraasen commented 8 years ago

Thanks @weshmashian! I think the default behavior should always be http-auth-mode="pass".

In what cases would the force option be useful? There doesn't seem like much benefit to using auth at all if Relay adds credentials to every request.

weshmashian commented 8 years ago

Thanks for the feedback @gunnaraasen!

As for the force option, I did not think of any use-case but thought it might come in useful regarding the related issue report.

I went ahead and simplified the whole patch, making it pass any Authorization header it finds directly to backend. Error-handling is non-existent as lack of such headers should not be a fatal error.

joelegasse commented 8 years ago

Please see my comments in #13. I'm going to close this for now, and we can revisit the code changes that will be required after a discussion in the issue.