influxdata / influxdb-relay

Service to replicate InfluxDB data for high availability
MIT License
855 stars 350 forks source link

Add build scripts and Godeps file #25

Closed rossmcdonald closed 8 years ago

rossmcdonald commented 8 years ago

@joelegasse Do you mind if I go ahead and merge this in? Only changes are related to build scripts so that community members can build their own packages if needed.

joelegasse commented 8 years ago

I would suggest removing support@influxdb.com as the maintainer. This is not an officially supported product.

rossmcdonald commented 8 years ago

Good catch, the maintainer and vendor information has been removed.

joelegasse commented 8 years ago

I also noticed a lot of bits still referencing rc and beta that won't apply to the relay. I'm not fond of the idea of just re-using the script as-is.

Can you clean it up so that it's stripped down for the purposes of allowing people to build their own packages?

rossmcdonald commented 8 years ago

@joelegasse Sure thing. I've removed most (if not all) functionality that doesn't apply to relay, including references to RC's, betas, testing, generating, uploads, and signing. The version scheme is also to just use the git hash since relay most likely won't ever be versioned.

Let me know if there's anything else you want me to strip out.

joelegasse commented 8 years ago

There are still references to signatures, minor versions, nightly vs. release... Maybe I'm overthinking this, but it just seems wrong to have all these codepaths that are never meant to be executed.

rossmcdonald commented 8 years ago

@joelegasse Sorry, I missed that last piece of signature functionality (now removed).

I mean I can try stripping out everything that will never apply, but at this point the script will be able to do what it's needed for and will provide a somewhat simple way for people who are unfamiliar with Go to create packages on their own. I don't see the reason for crippling the script to the point where it only does the bare minimum. Also community members may want to use some of the extra functionality for setting up their own build processes if they so wish in the future.

joelegasse commented 8 years ago

I guess that's acceptable. Feel free to merge when you're ready. 👍

rossmcdonald commented 8 years ago

Okay, great. Thanks for your help!