influxdata / influxdb

Scalable datastore for metrics, events, and real-time analytics
https://influxdata.com
Apache License 2.0
28.98k stars 3.56k forks source link

Header defaults #14069

Closed docmerlin closed 5 years ago

docmerlin commented 5 years ago

https://github.com/influxdata/influxdb/blob/master/http/swagger.yml#L5550

says that the default for Header in the flux spec is true, but when a Dialect field is not included, neither is a Header row.

This is running against the 2.0 alpha docker container.

Also we get an info level error in the logs:

ts=2019-06-05T21:02:46.270103Z lvl=info msg="Error writing response to client" log_id=0FrN2oql000 handler=query handler=flux error="csv encoder error: expected integer cursor type, got *reads.stringMultiShardArrayCursor" errorVerbose="expected integer cursor type, got *reads.stringMultiShardArrayCursor\ncsv encoder error\ngithub.com/influxdata/flux/csv.wrapEncodingError\n\t/go/pkg/mod/github.com/influxdata/flux@v0.23.0/csv/result.go:751\ngithub.com/influxdata/flux/csv.(*ResultEncoder).Encode.func1\n\t/go/pkg/mod/github.com/influxdata/flux@v0.23.0/csv/result.go:841\ngithub.com/influxdata/flux/execute.(*result).Do\n\t/go/pkg/mod/github.com/influxdata/flux@v0.23.0/execute/result.go:70\ngithub.com/influxdata/flux/csv.(*ResultEncoder).Encode\n\t/go/pkg/mod/github.com/influxdata/flux@v0.23.0/csv/result.go:769\ngithub.com/influxdata/flux.(*DelimitedMultiResultEncoder).Encode\n\t/go/pkg/mod/github.com/influxdata/flux@v0.23.0/result.go:248\ngithub.com/influxdata/influxdb/query.ProxyQueryServiceAsyncBridge.Query\n\t/go/src/github.com/influxdata/influxdb/query/bridges.go:103\ngithub.com/influxdata/influxdb/query.(*ProxyQueryServiceAsyncBridge).Query\n\t<autogenerated>:1\ngithub.com/influxdata/influxdb/http.(*FluxHandler).handleQuery\n\t/go/src/github.com/influxdata/influxdb/http/query_handler.go:114\ngithub.com/influxdata/influxdb/http.(*FluxHandler).handleQuery-fm\n\t/go/src/github.com/influxdata/influxdb/http/query_handler.go:76\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:1964\ngithub.com/julienschmidt/httprouter.(*Router).Handler.func1\n\t/go/pkg/mod/github.com/julienschmidt/httprouter@v1.2.0/params_go17.go:26\ngithub.com/julienschmidt/httprouter.(*Router).ServeHTTP\n\t/go/pkg/mod/github.com/julienschmidt/httprouter@v1.2.0/router.go:334\ngithub.com/influxdata/influxdb/http.(*APIHandler).ServeHTTP\n\t/go/src/github.com/influxdata/influxdb/http/api_handler.go:224\ngithub.com/influxdata/influxdb/http.(*AuthenticationHandler).ServeHTTP\n\t/go/src/github.com/influxdata/influxdb/http/authentication_middleware.go:86\ngithub.com/influxdata/influxdb/http.(*PlatformHandler).ServeHTTP\n\t/go/src/github.com/influxdata/influxdb/http/platform_handler.go:70\ngithub.com/influxdata/influxdb/http.(*Handler).ServeHTTP\n\t/go/src/github.com/influxdata/influxdb/http/handler.go:166\nnet/http.serverHandler.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2741\nnet/http.(*conn).serve\n\t/usr/local/go/src/net/http/server.go:1847\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1333"
stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

This issue has been automatically closed because it has not had recent activity. Please reopen if this issue is still important to you. Thank you for your contributions.