search

influxdata / influxdb

Scalable datastore for metrics, events, and real-time analytics
https://influxdata.com
Apache License 2.0
28.86k stars 3.55k forks source link

Add coarser grained retention check metrics #14446

Open e-dard opened 5 years ago

e-dard commented 5 years ago

Currently we track retention metrics by org, bucket etc.

https://github.com/influxdata/influxdb/blob/236322d86b557b4e74c62858db638a4ddead0a17/storage/metrics.go#L42-L73

I would like some extra metrics that don't include org_id or bucket_id.

It will make it easier to aggregate the metrics. Considering other metrics where we have done this, idiomatic field names for these new metrics would probably be: EngineChecks and EngineChecksDuration. Metric names probably storage_retention_engine_checks_total and storage_retention_engine_check_duration_seconds.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

samuelrey commented 4 years ago

Hey @e-dard , was wondering if this would still be helpful?

e-dard commented 4 years ago

@samuelrey thanks for checking in. I don't think we need this any more.

samuelrey commented 4 years ago

gotcha, no worries!

Any other issues that could use a hand? I'm new to the project, so maybe something on the easier side!