search

influxdata / influxdb

Scalable datastore for metrics, events, and real-time analytics
https://influxdata.com
Apache License 2.0
28.71k stars 3.54k forks source link

Please reconsider forking httprouter #16695

Open eclipseo opened 4 years ago

eclipseo commented 4 years ago

Back in https://github.com/influxdata/influxdb/commit/3dbb9c0fd2d8423a6116c3106e60fff23a6faeec you decided to fork julienschmidt/httprouter to influxdata/httprouter . I'd like you to reconsider forking project like this and move your changes upstream as much as possible. This fork will likely not be taken care off and will be cut from upstream updates and potential security fixes.

You already have forked this project before and it was never updated anymore: github.com/bouk/httprouter

So now you have 2 forks of the same project to add a single feature, which will never benefit from upstream updates.

russorat commented 4 years ago

@eclipseo thanks for the issue. @GeorgeMac what do you think? Was there a specific reason for the fork?

GeorgeMac commented 4 years ago

Thanks @eclipseo and @russorat ! I will get this on my radar as support for what we needed got merged into https://github.com/julienschmidt/httprouter/pull/286 It is slightly different shape to our fork, but solves the same problem. So I just need to do a bit of work to get the upstream change integrated.