influxdata / influxdb

Scalable datastore for metrics, events, and real-time analytics
https://influxdata.com
Apache License 2.0
28.19k stars 3.51k forks source link

Potential overflow panic #25041

Open tisonkun opened 1 month ago

tisonkun commented 1 month ago

https://github.com/influxdata/influxdb/blob/faab7a0abc87094b45f41f428b66cacc34b8216e/influxdb3_write/src/write_buffer/mod.rs#L709-L729

As we noticed at https://github.com/GreptimeTeam/greptimedb/issues/3739 and fixed at https://github.com/GreptimeTeam/greptimedb/pull/3794, L727 can encounter a overflow panic. Properly handle the overflow and return errors can be a better choice.