Write validator should produce `Row` for the WAL directly

influxdata / influxdb

Scalable datastore for metrics, events, and real-time analytics

https://influxdata.com

Apache License 2.0

28.91k stars 3.55k forks source link

Write validator should produce `Row` for the WAL directly #25512

Open hiltontj opened 2 hours ago

hiltontj commented 2 hours ago

See https://github.com/influxdata/influxdb/pull/25495#discussion_r1826188340

That PR changed the validator to produce a QualifiedLine which is basically just a Row that hasn't had the timestamp set yet. This extra abstraction can be removed and just have the validation step produce a row directly.

pauldix commented 1 hour ago

No reason we can't set the timestamp during validation, yeah?

hiltontj commented 1 hour ago

Yes we can just move that step up to the validate part. It is the only special thing that is being done with the QualifiedLine