Broken Build?

[keep94]

Bug report

System info: Github head version; linux

Steps to reproduce:

1. mkdir mygo
2. cd mygo
3. export GOPATH=~/mygo
4. go get github.com/influxdata/influxdb/...

Expected behavior: Influx should build successfully

Actual behavior: Influx fails to compile.

src/github.com/influxdata/influxdb/influxql/query_executor.go:184: undefined: zap.NullEncoder

[keep94]

uber-go/zap made breaking changes to their API.

Off master branch:

Last good zap version for influxdb: 61159f0 first version of zap with breaking changes: e5bfe32

[rossmcdonald]

You need to restore the correct dependencies using the included Godeps file. Please follow the instructions in contributing.md when building.

[keep94]

Not trying to contribute just trying to build the project. Shouldn't it build as-is when checked out from GitHub using go get? On Thu, 16 Feb 2017 at 12:50, Ross McDonald notifications@github.com wrote:

You need to restore the correct dependencies using the included Godeps file. Please follow the instructions in contributing.md https://github.com/influxdata/influxdb/blob/master/CONTRIBUTING.md#build-and-test when building.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/influxdata/influxdb/issues/8016#issuecomment-280455825, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrhckyBM7_IUomzS8CIqIQkRvdFOyzcks5rdLaEgaJpZM4MDTfG .

[rossmcdonald]

@keep94 No, since we don't vendor dependencies (yet). You need to use gdm to restore the pinned dependency commit, otherwise you'll get build errors due to go get pulling the latest version from each dependency. Your steps need to be updated to:

...
go get github.com/sparrc/gdm
go get github.com/influxdata/influxdb
cd $GOPATH/src/github.com/influxdata/influxdb
gdm restore
go install ./...

[keep94]

Thx I didn't see on contributing.md instructions to run gdm restore. Consider providing step by step directions for compiling

On Thu, 16 Feb 2017 at 12:58, Ross McDonald notifications@github.com wrote:

@keep94 https://github.com/keep94 No, since we don't vendor dependencies (yet). You need to use gdm to restore the pinned dependency commit, otherwise you'll get build errors due to go get pulling the latest version from each dependency. Your steps need to be updated to:

...

go get github.com/sparrc/gdm

go get github.com/influxdata/influxdb

cd $GOPATH/src/github.com/influxdata/influxdb

gdm restore

go install ./...

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/influxdata/influxdb/issues/8016#issuecomment-280458301, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrhcuGpORoyc_gvInedMsqRExvdfOmfks5rdLiKgaJpZM4MDTfG .

[wonderflow]

I meet the same problem and I use gdm restore, Unfortunately I got

ERROR restoring some imports:
-   Error checking out rev 416270f07a9f696922512bb6487df46a2238f73d of repo /Users/sunjianbo/gopath/src/go.uber.org/zap, exit status 128

[wonderflow]

master branch is ok