influxdata / openapi

An OpenAPI specification for influx (cloud/oss) apis.
MIT License
17 stars 10 forks source link

fix(tasks): `orgID` should not be required for `GetTasks` #606

Closed bednar closed 1 year ago

bednar commented 1 year ago

Caused by #591

The orgID parameter should not be required for GetTasks because the OSS implementation is able to works without this: https://github.com/influxdata/influxdb/blob/a0f1184bb3eeb8a6f8fa1bbdb9898d41355ff67f/kv/task.go#L227

curl -i -X GET http://localhost:8086/api/v2/tasks -H 'Authorization: Token my-token'
HTTP/1.1 200 OK
Content-Type: application/json; charset=utf-8
X-Influxdb-Build: OSS
X-Influxdb-Version: v2.5.0
Date: Sun, 06 Nov 2022 19:49:37 GMT
Content-Length: 673

{"links":{"self":"/api/v2/tasks?limit=100"},"tasks":[{"links":{"labels":"/api/v2/tasks/0a3f9de5d9a2e000/labels","logs":"/api/v2/tasks/0a3f9de5d9a2e000/logs","members":"/api/v2/tasks/0a3f9de5d9a2e000/members","owners":"/api/v2/tasks/0a3f9de5d9a2e000/owners","runs":"/api/v2/tasks/0a3f9de5d9a2e000/runs","self":"/api/v2/tasks/0a3f9de5d9a2e000"},"labels":[],"id":"0a3f9de5d9a2e000","orgID":"0c9c82f65519adcb","org":"my-org","ownerID":"0a39c2fb64bfb000","name":"testing","status":"active","flux":"option task = { \n  name: \"testing\",\n  every: 3h,\n}\n\nfrom(bucket: \"my-bucket\")","every":"3h","latestCompleted":"2022-11-06T19:45:42Z","createdAt":"2022-11-06T19:45:42Z"}]}

it also breaks our nightly builds for clients:

bednar commented 1 year ago

cc @jstirnaman, @glinton, @sunbryely-influxdata

Can you take a look?

bednar commented 1 year ago

@sunbryely-influxdata thanks for your approval. Can you merge this PR? I don't have a permission...