testifylint->blank-import - Should we enable it?

[zak-pawel]

Description

This issue starts a discussion about enabling:

• linter: testifylint - Checks usage of github.com/stretchr/testify.
• checker: blank-import - testify doesn't do any init() magic, so these imports as _ do nothing and considered useless.

Example

Before:

import (
    "testing"

    _ "github.com/stretchr/testify"
    _ "github.com/stretchr/testify/assert"
    _ "github.com/stretchr/testify/http"
    _ "github.com/stretchr/testify/mock"
    _ "github.com/stretchr/testify/require"
    _ "github.com/stretchr/testify/suite"
)

After:

import (
    "testing"
)

Expected output

Decision about enabling or not enabling this checker.

Findings

For this checker, no findings were found in the current codebase.

Additional configuration

For this checker, no additional configuration can be provided.

[zak-pawel]

Useful, revive->blankimports (which we have been using) doesn't find such imports for tests.

[srebhan]

Fine with me to enable this linter.

[powersj]

+1