search

influxdata / telegraf

Agent for collecting, processing, aggregating, and writing metrics, logs, and other arbitrary data.
https://influxdata.com/telegraf
MIT License
14.55k stars 5.56k forks source link

Deployment status of `testifylint` checkers #15539

Closed zak-pawel closed 2 months ago

zak-pawel commented 3 months ago

Current status:

Checker Issue To enable? PR(s) Work finished?
blank-import https://github.com/influxdata/telegraf/issues/15533 Y https://github.com/influxdata/telegraf/pull/15566 Y
bool-compare x Y https://github.com/influxdata/telegraf/pull/14163 https://github.com/influxdata/telegraf/pull/14238 Y
compares x Y https://github.com/influxdata/telegraf/pull/14177 https://github.com/influxdata/telegraf/pull/14238 Y
empty x Y https://github.com/influxdata/telegraf/pull/14179 https://github.com/influxdata/telegraf/pull/14238 Y
error-is-as x Y https://github.com/influxdata/telegraf/pull/14180 https://github.com/influxdata/telegraf/pull/14238 Y
error-nil x Y https://github.com/influxdata/telegraf/pull/14198 https://github.com/influxdata/telegraf/pull/14238 Y
expected-actual x Y https://github.com/influxdata/telegraf/pull/14229 https://github.com/influxdata/telegraf/pull/14238 Y
float-compare https://github.com/influxdata/telegraf/issues/15534 Y https://github.com/influxdata/telegraf/pull/15566 Y
formatter Checker not yet available in the newest golangci-lint (currently: v1.59.1)
go-require https://github.com/influxdata/telegraf/issues/15535 Y
len x Y https://github.com/influxdata/telegraf/pull/14203 https://github.com/influxdata/telegraf/pull/14238 Y
negative-positive https://github.com/influxdata/telegraf/issues/15536 Y https://github.com/influxdata/telegraf/pull/15566 Y
nil-compare https://github.com/influxdata/telegraf/issues/15537 Y https://github.com/influxdata/telegraf/pull/15566 Y
require-error x Y https://github.com/influxdata/telegraf/pull/14181 https://github.com/influxdata/telegraf/pull/14238 Y
suite-broken-parallel Checker not yet available in the newest golangci-lint (currently: v1.59.1)
suite-dont-use-pkg x Y https://github.com/influxdata/telegraf/pull/14238 Y
suite-extra-assert-call x Y https://github.com/influxdata/telegraf/pull/14238 Y
suite-subtest-run Checker not yet available in the newest golangci-lint (currently: v1.59.1)
suite-thelper x Y https://github.com/influxdata/telegraf/pull/14238 Y
useless-assert https://github.com/influxdata/telegraf/issues/15538 Y https://github.com/influxdata/telegraf/pull/15566 Y
powersj commented 3 months ago

next steps: wrap up new linter additions

powersj commented 2 months ago

@zak-pawel can we close this now that everything except https://github.com/influxdata/telegraf/issues/15535 has landed?

zak-pawel commented 2 months ago

@powersj Or we can wait until all the PRs are opened and merged ;) The first one should be ready within a few days.

powersj commented 2 months ago

What PRs are left? Based on the chart the only remaining rows do not have support in golangci-lint?

zak-pawel commented 2 months ago

@powersj go-require - 557 findings to address.

powersj commented 2 months ago

That is tracked already by https://github.com/influxdata/telegraf/issues/15535, closing this.