Linter: revive, Rule: `add-constant` - Suggests using constant for magic numbers and string literals. Should we enable it?

[zak-pawel]

Description

This issue starts a discussion about enabling:

• linter: revive - Fast, configurable, extensible, flexible, and beautiful linter for Go. Drop-in replacement of golint. Revive provides a framework for development of custom rules, and lets you define a strict preset for enhancing your development & code review processes.
• rule: add-constant - Suggests using constant for magic numbers and string literals.

Configuration:

• maxLitCount : (string) maximum number of instances of a string literal that are tolerated before warn.
• allowStrs: (string) comma-separated list of allowed string literals
• allowInts: (string) comma-separated list of allowed integers
• allowFloats: (string) comma-separated list of allowed floats
• ignoreFuncs: (string) comma-separated list of function names regexp patterns to exclude

Example configuration:

      - name: add-constant
        exclude: ["TEST"]
        arguments:
          - maxLitCount: "3"
            allowStrs: '""'
            allowInts: "0,1,2,3"
            allowFloats: "0.0,0.,1.0,1.,2.0,2.,3.0,3."
            ignoreFuncs: "os\\.*,fmt\\.Println,make"

Expected output

Decision about enabling or not enabling this rule.

Findings

For this rule (with above configuration), the following findings were found in the current codebase:

agent/tick.go:47:27                                                           revive  add-constant: avoid magic numbers like '100', create a named constant for it
cmd/telegraf/cmd_plugins.go:72:20                                             revive  add-constant: string literal "deprecated" appears, at least, 4 times, create a named constant for it
cmd/telegraf/cmd_plugins.go:73:60                                             revive  add-constant: string literal "inputs" appears, at least, 4 times, create a named constant for it
cmd/telegraf/cmd_plugins.go:91:61                                             revive  add-constant: string literal "outputs" appears, at least, 4 times, create a named constant for it
cmd/telegraf/cmd_plugins.go:104:15                                            revive  add-constant: string literal "print only deprecated plugins" appears, at least, 4 times, create a named constant for it
cmd/telegraf/cmd_plugins.go:109:64                                            revive  add-constant: string literal "processors" appears, at least, 4 times, create a named constant for it
cmd/telegraf/cmd_plugins.go:127:65                                            revive  add-constant: string literal "aggregators" appears, at least, 4 times, create a named constant for it
cmd/telegraf/cmd_plugins.go:145:66                                            revive  add-constant: string literal "secretstores" appears, at least, 4 times, create a named constant for it
cmd/telegraf/cmd_plugins.go:163:61                                            revive  add-constant: string literal "parsers" appears, at least, 4 times, create a named constant for it
cmd/telegraf/cmd_plugins.go:181:65                                            revive  add-constant: string literal "serializers" appears, at least, 4 times, create a named constant for it
cmd/telegraf/cmd_secretstore.go:21:32                                         revive  add-constant: string literal "-" appears, at least, 4 times, create a named constant for it
cmd/telegraf/main.go:83:61                                                    revive  add-constant: string literal ":" appears, at least, 4 times, create a named constant for it
cmd/telegraf/main.go:234:40                                                   revive  add-constant: string literal "plugin-directory" appears, at least, 4 times, create a named constant for it
cmd/telegraf/printer.go:179:62                                                revive  add-constant: string literal "none" appears, at least, 4 times, create a named constant for it
cmd/telegraf/printer.go:395:31                                                revive  add-constant: string literal "inputs" appears, at least, 4 times, create a named constant for it
cmd/telegraf/telegraf.go:388:78                                               revive  add-constant: string literal " " appears, at least, 4 times, create a named constant for it
cmd/telegraf/telegraf.go:417:16                                               revive  add-constant: avoid magic numbers like '1024', create a named constant for it
cmd/telegraf/telegraf.go:418:17                                               revive  add-constant: avoid magic numbers like '1024', create a named constant for it
config/config.go:127:32                                                       revive  add-constant: avoid magic numbers like '5', create a named constant for it
config/config.go:396:18                                                       revive  add-constant: avoid magic numbers like '6', create a named constant for it
config/config.go:396:38                                                       revive  add-constant: avoid magic numbers like '5', create a named constant for it
config/config.go:651:26                                                       revive  add-constant: string literal "error parsing %s, %w" appears, at least, 4 times, create a named constant for it
config/config.go:679:24                                                       revive  add-constant: string literal "unsupported config format: %s" appears, at least, 4 times, create a named constant for it
config/config.go:915:24                                                       revive  add-constant: string literal "secretstores" appears, at least, 4 times, create a named constant for it
config/config.go:1115:30                                                      revive  add-constant: string literal "processors" appears, at least, 4 times, create a named constant for it
config/config.go:1173:22                                                      revive  add-constant: string literal "plugin deprecated" appears, at least, 4 times, create a named constant for it
config/config.go:1266:30                                                      revive  add-constant: string literal "inputs" appears, at least, 4 times, create a named constant for it
config/config.go:1325:30                                                      revive  add-constant: avoid magic numbers like '100', create a named constant for it
config/config.go:1326:25                                                      revive  add-constant: avoid magic numbers like '30', create a named constant for it
config/config.go:1372:24                                                      revive  add-constant: string literal "log_level" appears, at least, 4 times, create a named constant for it
config/config.go:1485:28                                                      revive  add-constant: string literal "tags" appears, at least, 4 times, create a named constant for it
config/config.go:1530:24                                                      revive  add-constant: string literal "alias" appears, at least, 4 times, create a named constant for it
config/config.go:1556:3                                                       revive  add-constant: string literal "data_format" appears, at least, 4 times, create a named constant for it
config/config.go:1562:3                                                       revive  add-constant: string literal "name_override" appears, at least, 4 times, create a named constant for it
config/config.go:1562:20                                                      revive  add-constant: string literal "name_prefix" appears, at least, 4 times, create a named constant for it
config/config.go:1562:35                                                      revive  add-constant: string literal "name_suffix" appears, at least, 4 times, create a named constant for it
config/config.go:1600:19                                                      revive  add-constant: avoid magic numbers like '100', create a named constant for it
config/deprecation.go:206:10                                                  revive  add-constant: string literal "inputs" appears, at least, 4 times, create a named constant for it
config/deprecation.go:220:10                                                  revive  add-constant: string literal "outputs" appears, at least, 4 times, create a named constant for it
config/deprecation.go:234:10                                                  revive  add-constant: string literal "processors" appears, at least, 4 times, create a named constant for it
config/deprecation.go:248:10                                                  revive  add-constant: string literal "aggregators" appears, at least, 4 times, create a named constant for it
config/secret.go:234:81                                                       revive  add-constant: string literal ";" appears, at least, 4 times, create a named constant for it
config/types.go:29:38                                                         revive  add-constant: avoid magic numbers like '10', create a named constant for it
config/types.go:29:42                                                         revive  add-constant: avoid magic numbers like '64', create a named constant for it
config/types.go:36:40                                                         revive  add-constant: avoid magic numbers like '64', create a named constant for it
config/types.go:51:41                                                         revive  add-constant: avoid magic numbers like '64', create a named constant for it
config/types.go:55:50                                                         revive  add-constant: avoid magic numbers like '64', create a named constant for it
config/types.go:74:36                                                         revive  add-constant: avoid magic numbers like '10', create a named constant for it
config/types.go:74:40                                                         revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/content_coding.go:151:7                                              revive  add-constant: string literal "gzip" appears, at least, 4 times, create a named constant for it
internal/content_coding.go:209:17                                             revive  add-constant: avoid magic numbers like '1024', create a named constant for it
internal/content_coding.go:209:22                                             revive  add-constant: avoid magic numbers like '1024', create a named constant for it
internal/content_coding.go:303:7                                              revive  add-constant: avoid magic numbers like '7', create a named constant for it
internal/content_coding.go:305:7                                              revive  add-constant: avoid magic numbers like '11', create a named constant for it
internal/content_coding.go:371:17                                             revive  add-constant: avoid magic numbers like '1024', create a named constant for it
internal/content_coding.go:371:22                                             revive  add-constant: avoid magic numbers like '1024', create a named constant for it
internal/globpath/globpath.go:96:32                                           revive  add-constant: string literal "**" appears, at least, 4 times, create a named constant for it
internal/process/process.go:46:17                                             revive  add-constant: avoid magic numbers like '5', create a named constant for it
internal/rotate/file_writer.go:153:115                                        revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/snmp/config.go:47:19                                                 revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/snmp/field.go:150:46                                                 revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/snmp/field.go:156:38                                                 revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/snmp/field.go:194:42                                                 revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/snmp/field.go:194:46                                                 revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/snmp/field.go:196:34                                                 revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/snmp/field.go:196:38                                                 revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/snmp/field.go:288:8                                                  revive  add-constant: avoid magic numbers like '4', create a named constant for it
internal/snmp/field.go:288:11                                                 revive  add-constant: avoid magic numbers like '16', create a named constant for it
internal/snmp/wrapper.go:187:42                                               revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/snmp/wrapper.go:187:46                                               revive  add-constant: avoid magic numbers like '16', create a named constant for it
internal/templating/engine.go:61:28                                           revive  add-constant: avoid magic numbers like '4', create a named constant for it
internal/templating/node.go:125:22                                            revive  add-constant: string literal "*" appears, at least, 4 times, create a named constant for it
internal/type_conversions.go:15:32                                            revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/type_conversions.go:17:40                                            revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/type_conversions.go:19:41                                            revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/type_conversions.go:58:35                                            revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:61:43                                            revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:64:44                                            revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:108:58                                           revive  add-constant: avoid magic numbers like '16', create a named constant for it
internal/type_conversions.go:108:62                                           revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/type_conversions.go:110:31                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:110:35                                           revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/type_conversions.go:112:39                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:112:43                                           revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/type_conversions.go:114:40                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:114:44                                           revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/type_conversions.go:175:54                                           revive  add-constant: string literal "0x" appears, at least, 4 times, create a named constant for it
internal/type_conversions.go:175:61                                           revive  add-constant: avoid magic numbers like '16', create a named constant for it
internal/type_conversions.go:175:65                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:178:34                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:178:38                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:181:42                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:181:46                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:184:43                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:184:47                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:242:23                                           revive  add-constant: string literal "type \"%T\" unsupported" appears, at least, 4 times, create a named constant for it
internal/type_conversions.go:249:61                                           revive  add-constant: avoid magic numbers like '16', create a named constant for it
internal/type_conversions.go:249:65                                           revive  add-constant: avoid magic numbers like '16', create a named constant for it
internal/type_conversions.go:252:34                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:252:38                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:255:42                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:255:46                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:258:43                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:258:47                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:326:61                                           revive  add-constant: avoid magic numbers like '16', create a named constant for it
internal/type_conversions.go:326:65                                           revive  add-constant: avoid magic numbers like '8', create a named constant for it
internal/type_conversions.go:329:34                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:329:38                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:332:42                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:332:46                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:335:43                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:335:47                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:406:57                                           revive  add-constant: avoid magic numbers like '16', create a named constant for it
internal/type_conversions.go:406:61                                           revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/type_conversions.go:408:30                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:408:34                                           revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/type_conversions.go:410:38                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:410:42                                           revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/type_conversions.go:412:39                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:412:43                                           revive  add-constant: avoid magic numbers like '64', create a named constant for it
internal/type_conversions.go:464:60                                           revive  add-constant: avoid magic numbers like '16', create a named constant for it
internal/type_conversions.go:464:64                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:467:33                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:467:37                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:470:41                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:470:45                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:473:42                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:473:46                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:535:60                                           revive  add-constant: avoid magic numbers like '16', create a named constant for it
internal/type_conversions.go:535:64                                           revive  add-constant: avoid magic numbers like '16', create a named constant for it
internal/type_conversions.go:538:33                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:538:37                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:541:41                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:541:45                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:544:42                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:544:46                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:609:60                                           revive  add-constant: avoid magic numbers like '16', create a named constant for it
internal/type_conversions.go:609:64                                           revive  add-constant: avoid magic numbers like '8', create a named constant for it
internal/type_conversions.go:612:33                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:612:37                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:615:41                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:615:45                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:618:42                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:618:46                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:692:38                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:694:38                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:696:38                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:698:38                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:700:31                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:702:40                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:704:40                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:706:40                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:708:40                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:710:32                                           revive  add-constant: avoid magic numbers like '10', create a named constant for it
internal/type_conversions.go:712:51                                           revive  add-constant: avoid magic numbers like '32', create a named constant for it
internal/type_conversions.go:714:42                                           revive  add-constant: avoid magic numbers like '64', create a named constant for it
logger/handler.go:43:14                                                       revive  add-constant: avoid magic numbers like '99', create a named constant for it
migrations/inputs_httpjson/migration.go:61:10                                 revive  add-constant: string literal "name_override" appears, at least, 4 times, create a named constant for it
migrations/inputs_jolokia/migration.go:224:12                                 revive  add-constant: string literal "inputs" appears, at least, 4 times, create a named constant for it
models/buffer.go:89:4                                                         revive  add-constant: string literal "write" appears, at least, 4 times, create a named constant for it
models/running_aggregator.go:57:4                                             revive  add-constant: string literal "aggregate" appears, at least, 4 times, create a named constant for it
models/running_input.go:68:4                                                  revive  add-constant: string literal "gather" appears, at least, 4 times, create a named constant for it
models/running_output.go:130:4                                                revive  add-constant: string literal "write" appears, at least, 4 times, create a named constant for it
models/running_serializer.go:61:4                                             revive  add-constant: string literal "serializer" appears, at least, 4 times, create a named constant for it
plugins/aggregators/basicstats/basicstats.go:205:58                           revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/aggregators/derivative/derivative.go:40:64                            revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/aggregators/histogram/histogram.go:182:74                             revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/aggregators/histogram/histogram.go:188:72                             revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/aggregators/quantile/quantile.go:124:27                               revive  add-constant: avoid magic numbers like '0.25', create a named constant for it
plugins/aggregators/quantile/quantile.go:124:33                               revive  add-constant: avoid magic numbers like '0.5', create a named constant for it
plugins/aggregators/quantile/quantile.go:124:38                               revive  add-constant: avoid magic numbers like '0.75', create a named constant for it
plugins/common/cookie/cookie.go:127:23                                        revive  add-constant: avoid magic numbers like '200', create a named constant for it
plugins/common/cookie/cookie.go:127:48                                        revive  add-constant: avoid magic numbers like '299', create a named constant for it
plugins/common/jolokia2/gatherer.go:82:8                                      revive  add-constant: avoid magic numbers like '200', create a named constant for it
plugins/common/jolokia2/gatherer.go:84:8                                      revive  add-constant: avoid magic numbers like '404', create a named constant for it
plugins/common/mqtt/mqtt_v3.go:39:36                                          revive  add-constant: avoid magic numbers like '5', create a named constant for it
plugins/common/mqtt/mqtt_v3.go:136:23                                         revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/common/mqtt/mqtt_v5.go:47:36                                          revive  add-constant: avoid magic numbers like '5', create a named constant for it
plugins/common/opcua/client.go:137:68                                         revive  add-constant: string literal "None" appears, at least, 4 times, create a named constant for it
plugins/common/opcua/client.go:139:72                                         revive  add-constant: avoid magic numbers like '2048', create a named constant for it
plugins/common/opcua/client.go:159:39                                         revive  add-constant: avoid magic numbers like '32', create a named constant for it
plugins/common/opcua/opcua_util.go:44:13                                      revive  add-constant: avoid magic numbers like '2048', create a named constant for it
plugins/common/opcua/opcua_util.go:61:55                                      revive  add-constant: avoid magic numbers like '128', create a named constant for it
plugins/common/opcua/opcua_util.go:176:50                                     revive  add-constant: avoid magic numbers like '2048', create a named constant for it
plugins/common/opcua/opcua_util.go:249:35                                     revive  add-constant: string literal "auto" appears, at least, 4 times, create a named constant for it
plugins/common/proxy/connect.go:82:24                                         revive  add-constant: avoid magic numbers like '200', create a named constant for it
plugins/common/socket/datagram.go:125:43                                      revive  add-constant: avoid magic numbers like '8', create a named constant for it
plugins/common/socket/datagram.go:125:46                                      revive  add-constant: avoid magic numbers like '32', create a named constant for it
plugins/common/socket/splitters.go:65:8                                       revive  add-constant: avoid magic numbers like '4', create a named constant for it
plugins/common/socket/splitters.go:69:8                                       revive  add-constant: avoid magic numbers like '8', create a named constant for it
plugins/common/socket/splitters.go:78:14                                      revive  add-constant: avoid magic numbers like '8', create a named constant for it
plugins/common/socket/stream.go:83:43                                         revive  add-constant: avoid magic numbers like '8', create a named constant for it
plugins/common/socket/stream.go:83:46                                         revive  add-constant: avoid magic numbers like '32', create a named constant for it
plugins/common/socket/stream.go:107:46                                        revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/common/socket/stream.go:107:50                                        revive  add-constant: avoid magic numbers like '32', create a named constant for it
plugins/common/socket/stream.go:111:32                                        revive  add-constant: avoid magic numbers like '32', create a named constant for it
plugins/common/socket/stream.go:114:47                                        revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/common/socket/stream.go:114:51                                        revive  add-constant: avoid magic numbers like '32', create a named constant for it
plugins/common/socket/stream.go:118:33                                        revive  add-constant: avoid magic numbers like '32', create a named constant for it
plugins/common/starlark/builtins.go:144:36                                    revive  add-constant: string literal "%s: %w" appears, at least, 4 times, create a named constant for it
plugins/common/starlark/starlark.go:157:11                                    revive  add-constant: string literal "state" appears, at least, 4 times, create a named constant for it
plugins/common/yangmodel/decoder.go:170:19                                    revive  add-constant: avoid magic numbers like '4', create a named constant for it
plugins/common/yangmodel/decoder.go:178:33                                    revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/common/yangmodel/decoder.go:178:37                                    revive  add-constant: avoid magic numbers like '8', create a named constant for it
plugins/common/yangmodel/decoder.go:184:33                                    revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/common/yangmodel/decoder.go:184:37                                    revive  add-constant: avoid magic numbers like '16', create a named constant for it
plugins/common/yangmodel/decoder.go:190:33                                    revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/common/yangmodel/decoder.go:190:37                                    revive  add-constant: avoid magic numbers like '32', create a named constant for it
plugins/common/yangmodel/decoder.go:196:33                                    revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/common/yangmodel/decoder.go:196:37                                    revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/common/yangmodel/decoder.go:198:29                                    revive  add-constant: string literal "parsing %s %q failed: %w" appears, at least, 4 times, create a named constant for it
plugins/common/yangmodel/decoder.go:202:34                                    revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/common/yangmodel/decoder.go:202:38                                    revive  add-constant: avoid magic numbers like '8', create a named constant for it
plugins/common/yangmodel/decoder.go:208:34                                    revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/common/yangmodel/decoder.go:208:38                                    revive  add-constant: avoid magic numbers like '16', create a named constant for it
plugins/common/yangmodel/decoder.go:214:34                                    revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/common/yangmodel/decoder.go:214:38                                    revive  add-constant: avoid magic numbers like '32', create a named constant for it
plugins/common/yangmodel/decoder.go:220:34                                    revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/common/yangmodel/decoder.go:220:38                                    revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/common/yangmodel/decoder.go:226:35                                    revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/aerospike/aerospike.go:76:30                                   revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/aerospike/aerospike.go:77:39                                   revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/inputs/aerospike/aerospike.go:78:30                                   revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/inputs/aerospike/aerospike.go:80:30                                   revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/aerospike/aerospike.go:270:40                                  revive  add-constant: string literal ";" appears, at least, 4 times, create a named constant for it
plugins/inputs/aerospike/aerospike.go:318:33                                  revive  add-constant: string literal "=" appears, at least, 4 times, create a named constant for it
plugins/inputs/aerospike/aerospike.go:422:88                                  revive  add-constant: string literal "-" appears, at least, 4 times, create a named constant for it
plugins/inputs/aerospike/aerospike.go:422:93                                  revive  add-constant: string literal "_" appears, at least, 4 times, create a named constant for it
plugins/inputs/aerospike/aerospike.go:433:47                                  revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/aerospike/aerospike.go:433:51                                  revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/aerospike/aerospike.go:435:48                                  revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/aerospike/aerospike.go:435:52                                  revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/aerospike/aerospike.go:439:49                                  revive  add-constant: avoid magic numbers like '32', create a named constant for it
plugins/inputs/aerospike/aerospike.go:448:3                                   revive  add-constant: string literal "aerospike_host" appears, at least, 4 times, create a named constant for it
plugins/inputs/aerospike/aerospike.go:449:3                                   revive  add-constant: string literal "node_name" appears, at least, 4 times, create a named constant for it
plugins/inputs/aliyuncms/aliyuncms.go:275:76                                  revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/aliyuncms/aliyuncms.go:279:60                                  revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/aliyuncms/aliyuncms.go:280:64                                  revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/aliyuncms/aliyuncms.go:329:48                                  revive  add-constant: avoid magic numbers like '1000', create a named constant for it
plugins/inputs/aliyuncms/discovery.go:247:23                                  revive  add-constant: avoid magic numbers like '20', create a named constant for it
plugins/inputs/amd_rocm_smi/amd_rocm_smi.go:152:63                            revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/amd_rocm_smi/amd_rocm_smi.go:152:67                            revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/amd_rocm_smi/amd_rocm_smi.go:154:67                            revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/amd_rocm_smi/amd_rocm_smi.go:154:71                            revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/amd_rocm_smi/amd_rocm_smi.go:155:50                            revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/amd_rocm_smi/amd_rocm_smi.go:174:14                            revive  add-constant: string literal "int" appears, at least, 4 times, create a named constant for it
plugins/inputs/amd_rocm_smi/amd_rocm_smi.go:179:94                            revive  add-constant: string literal "(Mhz)" appears, at least, 4 times, create a named constant for it
plugins/inputs/amd_rocm_smi/amd_rocm_smi.go:181:14                            revive  add-constant: string literal "float" appears, at least, 4 times, create a named constant for it
plugins/inputs/amd_rocm_smi/amd_rocm_smi.go:209:38                            revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/amd_rocm_smi/amd_rocm_smi.go:221:7                             revive  add-constant: string literal "int64" appears, at least, 4 times, create a named constant for it
plugins/inputs/amd_rocm_smi/amd_rocm_smi.go:223:36                            revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/amd_rocm_smi/amd_rocm_smi.go:223:40                            revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/amd_rocm_smi/amd_rocm_smi.go:228:7                             revive  add-constant: string literal "str" appears, at least, 4 times, create a named constant for it
plugins/inputs/amqp_consumer/amqp_consumer.go:104:21                          revive  add-constant: avoid magic numbers like '50', create a named constant for it
plugins/inputs/amqp_consumer/amqp_consumer.go:108:30                          revive  add-constant: avoid magic numbers like '1000', create a named constant for it
plugins/inputs/apache/apache.go:127:44                                        revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/bcache/bcache.go:58:37                                         revive  add-constant: avoid magic numbers like '32', create a named constant for it
plugins/inputs/bcache/bcache.go:94:46                                         revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/bcache/bcache.go:94:50                                         revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/beat/beat.go:170:13                                            revive  add-constant: string literal "beat" appears, at least, 4 times, create a named constant for it
plugins/inputs/bind/json_stats.go:91:7                                        revive  add-constant: string literal "type" appears, at least, 4 times, create a named constant for it
plugins/inputs/bind/xml_stats_v2.go:128:7                                     revive  add-constant: string literal "type" appears, at least, 4 times, create a named constant for it
plugins/inputs/bond/bond.go:161:33                                            revive  add-constant: string literal "error inspecting %q interface: %w" appears, at least, 4 times, create a named constant for it
plugins/inputs/bond/bond.go:216:3                                             revive  add-constant: string literal "bond" appears, at least, 4 times, create a named constant for it
plugins/inputs/bond/bond.go:240:11                                            revive  add-constant: string literal "status" appears, at least, 4 times, create a named constant for it
plugins/inputs/burrow/burrow.go:191:26                                        revive  add-constant: avoid magic numbers like '90', create a named constant for it
plugins/inputs/burrow/burrow.go:449:10                                        revive  add-constant: avoid magic numbers like '4', create a named constant for it
plugins/inputs/burrow/burrow.go:451:10                                        revive  add-constant: avoid magic numbers like '5', create a named constant for it
plugins/inputs/burrow/burrow.go:453:10                                        revive  add-constant: avoid magic numbers like '6', create a named constant for it
plugins/inputs/ceph/ceph.go:658:21                                            revive  add-constant: string literal "failed to parse json: %q: %w" appears, at least, 4 times, create a named constant for it
plugins/inputs/cgroup/cgroup_linux.go:235:32                                  revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cgroup/cgroup_linux.go:235:36                                  revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/chrony/chrony.go:62:52                                         revive  add-constant: avoid magic numbers like '8', create a named constant for it
plugins/inputs/chrony/chrony.go:62:55                                         revive  add-constant: avoid magic numbers like '32', create a named constant for it
plugins/inputs/chrony/chrony.go:153:33                                        revive  add-constant: string literal "udp" appears, at least, 4 times, create a named constant for it
plugins/inputs/chrony/chrony.go:274:60                                        revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/chrony/chrony.go:345:4                                         revive  add-constant: string literal "ntp_hits" appears, at least, 4 times, create a named constant for it
plugins/inputs/chrony/chrony.go:346:4                                         revive  add-constant: string literal "ntp_drops" appears, at least, 4 times, create a named constant for it
plugins/inputs/chrony/chrony.go:351:4                                         revive  add-constant: string literal "cmd_hits" appears, at least, 4 times, create a named constant for it
plugins/inputs/chrony/chrony.go:352:4                                         revive  add-constant: string literal "cmd_drops" appears, at least, 4 times, create a named constant for it
plugins/inputs/chrony/chrony.go:353:4                                         revive  add-constant: string literal "log_drops" appears, at least, 4 times, create a named constant for it
plugins/inputs/chrony/chrony.go:438:9                                         revive  add-constant: string literal "source" appears, at least, 4 times, create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go:489:54              revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go:491:46              revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go:493:52              revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go:495:45              revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go:497:56              revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go:499:64              revive  add-constant: avoid magic numbers like '32', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go:665:60              revive  add-constant: string literal "-" appears, at least, 4 times, create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go:665:65              revive  add-constant: string literal "_" appears, at least, 4 times, create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go:680:15              revive  add-constant: string literal "/" appears, at least, 4 times, create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go:726:56              revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go:733:54              revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:19:53              revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:22:45              revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:25:51              revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:28:44              revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:47:44              revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:59:44              revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:59:48              revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:71:43              revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:71:47              revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:83:44              revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:98:46              revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:126:54             revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:126:58             revive  add-constant: avoid magic numbers like '32', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:156:54             revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:156:58             revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:181:32             revive  add-constant: string literal "string" appears, at least, 4 times, create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:182:37             revive  add-constant: string literal "float" appears, at least, 4 times, create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:510:19             revive  add-constant: string literal "expires" appears, at least, 4 times, create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:528:19             revive  add-constant: string literal "uptime" appears, at least, 4 times, create a named constant for it
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_util.go:794:19             revive  add-constant: string literal "name" appears, at least, 4 times, create a named constant for it
plugins/inputs/clickhouse/clickhouse.go:547:24                                revive  add-constant: avoid magic numbers like '300', create a named constant for it
plugins/inputs/clickhouse/clickhouse.go:549:51                                revive  add-constant: avoid magic numbers like '200', create a named constant for it
plugins/inputs/clickhouse/clickhouse.go:577:41                                revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/clickhouse/clickhouse.go:577:45                                revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/cloudwatch/cloudwatch.go:507:14                                revive  add-constant: avoid magic numbers like '25', create a named constant for it
plugins/inputs/cloudwatch/cloudwatch.go:509:14                                revive  add-constant: avoid magic numbers like '500', create a named constant for it
plugins/inputs/cloudwatch/cloudwatch.go:521:33                                revive  add-constant: string literal "_" appears, at least, 4 times, create a named constant for it
plugins/inputs/cloudwatch_metric_streams/cloudwatch_metric_streams.go:269:21  revive  add-constant: string literal "error in bad-request: %v" appears, at least, 4 times, create a named constant for it
plugins/inputs/cloudwatch_metric_streams/cloudwatch_metric_streams.go:282:38  revive  add-constant: avoid magic numbers like '1000000', create a named constant for it
plugins/inputs/cloudwatch_metric_streams/cloudwatch_metric_streams.go:370:19  revive  add-constant: string literal "Content-Type" appears, at least, 4 times, create a named constant for it
plugins/inputs/cloudwatch_metric_streams/cloudwatch_metric_streams.go:370:35  revive  add-constant: string literal "application/json" appears, at least, 4 times, create a named constant for it
plugins/inputs/cloudwatch_metric_streams/cloudwatch_metric_streams.go:404:33  revive  add-constant: string literal "cloudwatch_metric_streams" appears, at least, 4 times, create a named constant for it
plugins/inputs/conntrack/conntrack.go:98:51                                   revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/couchbase/couchbase.go:128:29                                  revive  add-constant: string literal "cluster" appears, at least, 4 times, create a named constant for it
plugins/inputs/couchbase/couchbase.go:461:12                                  revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/couchdb/couchdb.go:123:13                                      revive  add-constant: avoid magic numbers like '4', create a named constant for it
plugins/inputs/couchdb/couchdb.go:142:28                                      revive  add-constant: avoid magic numbers like '200', create a named constant for it
plugins/inputs/cpu/cpu.go:105:24                                              revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/inputs/cpu/cpu.go:106:24                                              revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/inputs/cpu/cpu.go:107:24                                              revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/inputs/cpu/cpu.go:108:24                                              revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/inputs/cpu/cpu.go:109:24                                              revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/inputs/cpu/cpu.go:110:24                                              revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/inputs/cpu/cpu.go:111:24                                              revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/inputs/cpu/cpu.go:112:24                                              revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/inputs/cpu/cpu.go:113:24                                              revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/inputs/cpu/cpu.go:114:24                                              revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/inputs/cpu/cpu.go:117:30                                              revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/inputs/cpu/cpu.go:160:13                                              revive  add-constant: string literal "cpu" appears, at least, 4 times, create a named constant for it
plugins/inputs/csgo/csgo.go:85:21                                             revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/csgo/csgo.go:89:45                                             revive  add-constant: avoid magic numbers like '32', create a named constant for it
plugins/inputs/csgo/csgo.go:93:47                                             revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/csgo/csgo.go:97:48                                             revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/csgo/csgo.go:101:55                                            revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/csgo/csgo.go:105:46                                            revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/csgo/csgo.go:109:45                                            revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/csgo/csgo.go:113:49                                            revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/csgo/csgo.go:117:46                                            revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/csgo/csgo.go:121:47                                            revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/csgo/csgo.go:125:46                                            revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/ctrlx_datalayer/ctrlx_datalayer.go:95:24                       revive  add-constant: avoid magic numbers like '200', create a named constant for it
plugins/inputs/ctrlx_datalayer/ctrlx_datalayer.go:95:50                       revive  add-constant: avoid magic numbers like '201', create a named constant for it
plugins/inputs/dcos/client.go:304:23                                          revive  add-constant: avoid magic numbers like '200', create a named constant for it
plugins/inputs/dcos/client.go:304:49                                          revive  add-constant: avoid magic numbers like '300', create a named constant for it
plugins/inputs/directory_monitor/directory_monitor.go:430:48                  revive  add-constant: string literal "directory_monitor" appears, at least, 4 times, create a named constant for it
plugins/inputs/disk/disk.go:67:45                                             revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/inputs/disk/disk.go:73:57                                             revive  add-constant: avoid magic numbers like '100', create a named constant for it
plugins/inputs/diskio/diskio_linux.go:103:15                                  revive  add-constant: avoid magic numbers like '4', create a named constant for it
plugins/inputs/disque/disque.go:184:39                                        revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/disque/disque.go:184:43                                        revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/disque/disque.go:190:40                                        revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/dmcache/dmcache_linux.go:66:19                                 revive  add-constant: avoid magic numbers like '15', create a named constant for it
plugins/inputs/dmcache/dmcache_linux.go:71:51                                 revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/dmcache/dmcache_linux.go:71:55                                 revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/dmcache/dmcache_linux.go:76:62                                 revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/dmcache/dmcache_linux.go:76:66                                 revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/dmcache/dmcache_linux.go:84:59                                 revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/dmcache/dmcache_linux.go:84:63                                 revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/dmcache/dmcache_linux.go:88:60                                 revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/dmcache/dmcache_linux.go:88:64                                 revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/dmcache/dmcache_linux.go:92:59                                 revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/dmcache/dmcache_linux.go:92:63                                 revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/dmcache/dmcache_linux.go:100:53                                revive  add-constant: avoid magic numbers like '10', create a named constant for it
plugins/inputs/dmcache/dmcache_linux.go:100:57                                revive  add-constant: avoid magic numbers like '64', create a named constant for it
plugins/inputs/dmcache/dmcache_linux.go:104:54                                revive  add-constant: avoid magic numbers like '10', create a named constant for it
...
Total: 1996 issues

[srebhan]

I think we definitively need to exclude strconv.Parse* and strconv.Format* for this linter (see e.g. plugins/inputs/dmcache/dmcache_linux.go). In general I don't like to define constants for those per-se as often the meaning is clear at the usage place, e.g. defining default values for things in Init(). Quite the contrary, often defining defaults as consts means you need to jump around in code to get the actual value...

So I'm inclined to not enable this one...

[zak-pawel]

So I'm inclined to not enable this one...

Me too