influxdata / ui

UI for InfluxDB
94 stars 42 forks source link

Epic: Bulk Action #3128

Closed hoorayimhelping closed 2 years ago

hoorayimhelping commented 3 years ago

User Story

As a user, I want to be able to perform the same action, like deleting or adding a label to a number of resources at once

For now, (3/15/22) we will limit the scope to the API Tokens page and limit the Bulk Action to just Delete.

    Acceptance Criteria
    - The API Tokens page has a Global Checkbox component
    - The API Tokens page has a Checkbox component on each Token component
    - The user should be able to select all via the Global Checkbox component
    - The user should be able to select 1 via the individual checkbox component per token
    - Once at least one token is selected, show the "Delete Selected" Button
    - After the user clicks the "Delete Selected" Button, display a hover box asking "Are you sure you want to delete?"
    - If all items are de-selected, then the "Delete Selected" button should disappear 

    Dev Notes
    - See Figma Prototype: https://www.figma.com/file/KvIPhGVlAoG5CCBB7LFema/Misc-Mocks?node-id=0%3A1
kristinarobinson commented 2 years ago

Here are all the places where a Bulk Action could be implemented, and the associated actions... @brandenTenbrink @taramk

Luckette commented 2 years ago

@brandenTenbrink @taramk Any design update for Bulk Action on the API Tokens page?

brandenTenbrink commented 2 years ago

@brandenTenbrink @taramk Any design update for Bulk Action on the API Tokens page?

Being paired on later today!

Luckette commented 2 years ago

Awesome!

On Tue, Mar 22, 2022 at 2:26 PM brandenTenbrink @.***> wrote:

@brandenTenbrink https://github.com/brandenTenbrink @taramk https://github.com/taramk Any design update for Bulk Action on the API Tokens page?

Being paired on later today!

— Reply to this email directly, view it on GitHub https://github.com/influxdata/ui/issues/3128#issuecomment-1075479646, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXNFTZJUKQNKL6GPNJRUTALVBIGFLANCNFSM5HHDVN7A . You are receiving this because you commented.Message ID: @.***>

-- Amy Luckette, MS, CSPO Sr. Product Manager @.*** (315)663-1471

brandenTenbrink commented 2 years ago

Bulk_ None Selected Bulk_ X Selected Bulk_ All Selected

Here is the results of us pairing. The text of the delete confirmation (if we want that at all) can be changed obviously. Was just a quick and dirty type up lol

This will require some additional work in the Clockface repo that I will have to do--namely:

  1. Need to update the Toggle component to support the deselect state.
  2. Need to update the lighter choice of grey used here, to help stand out against the background of the api token panel.
  3. Additional Icon

I will also say that this solution would be limited to the API token (or any other location that does not have any left-most aligned content already. There would need to be some additional consideration if we expand this out to every location. Some existing things might need to be relocated)

brandenTenbrink commented 2 years ago

https://github.com/influxdata/clockface/pull/752

This icon should allow you to now use the existing Input (toggle) to add a deselection checkbox.

Let me know if we need any other functionality changes, but I don't think we do.