Open wiedld opened 2 years ago
Assigned this to myself for now. Since this issue is intertwined with another issue I am currently working upon. So not sure yet if (or how much) of this will be resolved as I am in progress of fixing the other ticket.
we decided to not pull out the monitor.check() yet, for reasons here: https://github.com/influxdata/ui/issues/4081#issuecomment-1074584517
But we are utilizing more schema awareness in the notebooks alerts. As in this PR: https://github.com/influxdata/ui/pull/4067
is not perfect. But is a patch until a broader product decision (updates) are made.
Could not reach team consensus on resolution. Then we decided to not do more fixes to notebooks.
About the bug
Steps to reproduce: List the minimal actions needed to reproduce the behavior.
trigger = (r) => r["co"] > 20 and (r["water_level"] > 0 and r["water_level"] < 100) and r["types"] == "earthquake"
.
Expected behavior: I should not be able to create threshold alerts, based on my dataset, which fail when I run the alert task.
.
Proposed solutions:
Either we can: A. decide to only allow numeric fields to be used in the notebook alerts B. permit string and numeric fields in threshold checks
Option A: only allow numeric fields
implementation details:
fields
for thresholds, from the returned dataset in the table view.Option B: permit multiple field types?
implementation details:
we would need to stop using the
monitor.check()
methodthen use flux like: