search

influxdata / ui

UI for InfluxDB
94 stars 42 forks source link

Tech Debt: Make use of InfluxDBCloudLogo consistent #4544

Closed hoorayimhelping closed 1 year ago

hoorayimhelping commented 2 years ago

During the process of fixing https://github.com/influxdata/ui/issues/4443, it was discovered that the <InfluxDBCloudLogo /> has a few inconsistent uses across the codebase. They should be cleaned up and made consistent in their uses so that it's clear how the logo should be used

wdoconnell commented 2 years ago

Spoke to Branden: There is an easier way we can make this consistent across all pages using the InfluxLogo component. I'll open a ticket and self-assign.

wdoconnell commented 2 years ago

Update: there is a new clockface component, <InfluxLogo />, that we can use to standardize the instances of <InfluxDBCloudLogo /> (and maybe other logos). It's not implemented in the codebase yet, and unfortunately the size and className props won't play nicely with resizing at the moment. I recommend keeping the uses of <InfluxDBCloudLogo /> as-is for now. Branden and I are touching base next week re: potential updates to the Clockface component so that it supports alternate sizes.

  1. UI if using . Screen Shot 2022-05-10 at 4 54 04 PM

  2. UI test using (oversized). Screen Shot 2022-05-10 at 4 57 56 PM

wdoconnell commented 1 year ago

Closing due to priority.