influxdata / ui

UI for InfluxDB
89 stars 41 forks source link

fix: downgrade rudderstack so debug is not pulled in #6879

Closed david-rusnak closed 3 months ago

david-rusnak commented 3 months ago

Closes https://github.com/influxdata/idpe/issues/18591

Downgrades rudderstack to not pull in debug 0.7.4. Hopefully this version is ok, in the future we will probably remove rudderstck completely since it has been deprecated.

Checklist

Authors and Reviewer(s), please verify the following:

david-rusnak commented 3 months ago

@wdoconnell Yeah just double checked, still brings in 0.7.4.

jdstrand commented 3 months ago

This looks ok to me in general, but I thought the rudderstack was updated recently to fix a different issue with CI tests? Something about it or a dependency that an earlier rudderstack used wasn't installable?

That said, this did pass tests, so I guess it's not a problem.

david-rusnak commented 3 months ago

@jdstrand

Yeah 2.14 had something that broke our CI, but then upgrading it to latest broke our linting because it added new types that weren't compatible - so I had to find a version that still worked for our version of typescript