search

influxdata / wirey

Manage local wireguard interfaces in a distributed system
Apache License 2.0
67 stars 6 forks source link

feat(backends): consul cloud discovery and go modules #22

Closed marcotuna closed 4 years ago

marcotuna commented 5 years ago

This patch enables:

Usage example using go-sockaddr: wirey --endpoint '{{GetInterfaceIP "wlp2s0"}}' --ipaddr 192.168.40.99 --consul '{{GetInterfaceIP "tun0"}}' --endpoint-port 5555

Usage example using go-discover wirey --endpoint 192.168.33.11 --ipaddr 172.30.0.4 --consul 192.168.33.10 --endpoint-port 5555 --discover "provider=scaleway organization=ORGANIZATION_ID tag_name=consul token=TOKEN_ID region=par1

marcotuna commented 5 years ago

cc @fntlnz

BondAnthony commented 5 years ago

@marcotuna thank you for contributing to Wirey!

Do you mind splitting the migration to Go modules into it's own PR and updating the CI steps to include the install of bzr apt-get install -y --no-install-recommends bzr. Circle is failing because it's unable to download a dependency. I think its alright to expect developers to have bzr installed but we need to include it in CI.

BondAnthony commented 5 years ago

@marcotuna if you could, please fill out our CLA

marcotuna commented 5 years ago

Hello @BondAnthony I've submited the CLA. About the issues you pointed, I will take a look and change it in order to be compliant with Influx requirements as soon as I get some free time.

marcotuna commented 5 years ago

@BondAnthony about the separation of this PR with Go modules, how do you suggest doing it? Or, is it really needed? The issue about the bzr dependency is gone, it was due to a lot of junk on my go.mod file, I cleaned it up

BondAnthony commented 5 years ago

Great thank you, that cleanup should be good so you can ignore my comment. Thanks

marcotuna commented 5 years ago

@BondAnthony, since this commits are a few months old and new the "Semantic Pull Request" is only here recently, is it possible to merge this PR and from now on the next PR's will be more organized and will follow the semantic convention, is it possible? Because there are too many changes and now it's hard to get that changed into different PR's. I would like to contribute with more improvements but I would like to see this going further.

BondAnthony commented 5 years ago

@marcotuna sorry for the delay yes we can take care of the semantic check. I'm validating no major issues with this change. Thank you again for opening the PR.