Closed 0xDmtri closed 7 months ago
Did you intentionally or accidentially close this PR? If the former, would you be ok if we used your changes as a base for a new PR?
Did you intentionally or accidentially close this PR? If the former, would you be ok if we used your changes as a base for a new PR?
Hey, intentionally because of the mess I made there haha. I am on track of redesigning my previous logic into something better. I will make a new PR today in the evening. Sounds good?
Sounds good :+1:
Description
Improved error handling and exhaustive handling of all the possible error codes. In original implementation only two variants of enum were handled in conditional manner (which is not robust in this case). The proposed usage of pattern matching via "match" case is a better way of handling errors. I have proposed a new enum variant for an Error that returns the standardized error code instead.
Let me know if there are any further suggestions for improvement.
Checklist
cargo fmt --all
cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features use-serde,derive,reqwest-client -- -D warnings
cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features use-serde,derive,hyper-client -- -D warnings
cargo doc2readme -p influxdb --expand-macros