influxdb-rs / influxdb-rust

Rust Client for the InfluxDB Time Series Database
https://crates.io/crates/influxdb
MIT License
256 stars 78 forks source link

Add time crate support for Timestamp #151

Open pbzweihander opened 7 months ago

pbzweihander commented 7 months ago

Description

{ describe your changes here }

Checklist

msrd0 commented 7 months ago

Thanks, adding time support is something I wanted to see for a long time but never got around to it!

I haven't actually checked where exactly we use chrono, but if it's only for the Timestamp, do you think you could make both chrono and time optional? I feel like most users wouldn't need both at the same time

pbzweihander commented 7 months ago

@msrd0 I've updated the PR!

Empty2k12 commented 7 months ago

The tests need to be adapted to test both chrono and time independently. The tests should enable the features. Ci is currently failing since chrono could not be found in the test.

msrd0 commented 7 months ago

The tests need to be adapted to test both chrono and time independently.

I'm not sure that's necessary. These two features don't seem to conflict each other.