infoactive / data-design

365 stars 147 forks source link

Ch 02 table overflow #8

Closed wetherc closed 10 years ago

wetherc commented 10 years ago

The table on line 60 x-overflows. Not a problem for HTML, but for any print builds that's going to be truncated.

wetherc commented 10 years ago

So does the table at line 380

wetherc commented 10 years ago

Same for table at line 103 in chapter 09

wetherc commented 10 years ago

And table at line 64, chapter 13; And at line 242, chapter 13

trinachi commented 10 years ago

Not sure about the best solution for this. Should we decrease the number of columns or replace with an image for print builds. Or...?

wetherc commented 10 years ago

Well, for Chapter 2, we can just chop off the data for years 2007 and 2008. Chapter 9 we could transpose, but that'd be just a weird presentation... A static image might be better for that one. Same goes for ch. 13, I think

trinachi commented 10 years ago

I skimmed the PDF build and didn't see any places where it looks like this is an issue, but I may have missed something. Bigger challenge for me is PDF css as a whole

http://orm-atlas2-prod.s3.amazonaws.com/pdf/a11f88dd220b4dd6c0da05d5a33f759b.pdf

Will check epub & mobi next...

trinachi commented 10 years ago

epub: http://orm-atlas2-prod.s3.amazonaws.com/epub/feefeea2df18f27e8b129d3d46b7acf5.epub

errors generating mobi...

wetherc commented 10 years ago

Can the Atlas folks offer any help with the styling for the PDF? CSS for print media is pretty universally just a beast...