search

infobip / infobip-api-csharp-client

Infobip API client library in C#, distributed as a NuGet package.
https://www.infobip.com/docs/api
MIT License
11 stars 17 forks source link

Template id is integer and should be a long or string #28

Closed moisoiu closed 8 months ago

moisoiu commented 8 months ago

Hello,

Description:

Version: 2.1.2 Environment : Production Reproducing : Any Id that is generated by InfoBip platform that is longer than the int

Suggest a Fix:

Can we change in the SendEmailApi.cs from 

int? templateid = default(int?)

to

string? templateid = default(string?)

or 

long? templateid = default(long?)

The issue seems to be fixed on Java https://github.com/infobip/infobip-api-java-client/blob/master/src/main/java/com/infobip/api/EmailApi.java

But the issue is not fixed on other libraries (Ex: php -> https://github.com/infobip/infobip-api-php-client/blob/master/Infobip/Api/EmailApi.php)

moisoiu commented 8 months ago

The issue was also reported here: https://github.com/infobip/infobip-api-java-client/issues/37

lvukadinovic-ib commented 8 months ago

Hi @moisoiu, thank you for using our library and for reporting the issue. We've released a new version (2.1.3) which fixes the mentioned problem. I'm marking this as closed. Feel free to reopen the issue if it still persists.

Kind regards, Luka