search

infobip / infobip-api-csharp-client

Infobip API client library in C#, distributed as a NuGet package.
https://www.infobip.com/docs/api
MIT License
11 stars 17 forks source link

Migrate to .Net Standard #3

Closed lira92 closed 3 years ago

lira92 commented 6 years ago

Hi, this library use .net 4.5, this is bad because the .net core users can't use this library, I suggest to migrate to .net standard 1.3, that support more versions, how you can see in this link https://docs.microsoft.com/pt-br/dotnet/standard/net-standard.

MirzaAbazovic commented 6 years ago

@lira92
Hi I have migrated this package to netstandard 1.3 code is here https://github.com/MirzaAbazovic/infobip-api-csharp-client/tree/master/InfobipClientNetStandard Package is here https://www.nuget.org/packages/Infobip.Api.Client.NetStandard/1.0.1

Porting to netstandard 2.0 was pretty straightforward but to go to 1.3 I had to implement NameValueCollection ParseQueryString(string requestQueryString) because of lack of System.Web.HttpUtility for netstandard 1.3

@hkozacinski Please feel free to use code (maybe pull request ?). Maybe we should add same tests. I'm willing to help :)

lira92 commented 6 years ago

@MirzaAbazovic nice, I have migrated too some time ago and already has a PR for this. The package is available here https://www.myget.org/feed/lira92/package/nuget/Infobip.Api.Client

sadiqna commented 5 years ago

@MirzaAbazovic Can you share nuget for .netstandard 2 ? .It will be helpful .Gonna start new project

MirzaAbazovic commented 5 years ago

@sadiqna I think that https://www.nuget.org/packages/Infobip.Api.Client.NetStandard/1.0.0 is net standard 2 because I first moved to 2 then downgrade it to 1.3 as You can see here https://github.com/MirzaAbazovic/infobip-api-csharp-client/commits/master

ivan-letenko commented 3 years ago

Hi, We just released a new major version of the library, now it is based on .NET Standard 2.0. Code contained within this repository is auto-generated, hence the changes will need to be made by us within library generation configuration. Feel free to open issues on the repository for any issue or feature request.