search

infobip / jira-version-generator

Apache License 2.0
27 stars 6 forks source link

Upgrade Stash dependencies to 3.7.2 #6

Closed mdoninger closed 8 years ago

mdoninger commented 8 years ago

The API in Stash was changed with version 3, so the plugin didn't work properly. This commit updates the dependency to Stash 3.7.2 and uses the new APIs (like Commit instead of Changeset etc.).

We had problems to install this plugin in our Stash instance which runs on version 3.7.2. So i updated the plugin to reflect the current API and remove deprecated API calls etc. Feel free to incorporate this pull request into your codebase.

Testing with Stash/Bitbucket Server 4.0 still pending, but i think with the current API usage it should work.

mbjelac commented 8 years ago

I just realized that we have Stash 3.8.0 and the plugin works fine. Although I think we installed it on an earlier Stash version and then upgraded it, but anyway - the plugin is still working with the old API on the new Stash version. @lpandzic - any ideas why it still works for us? :)

lpandzic commented 8 years ago

I wonder why it doesn't work for @mdoninger :) In Stash 3.7 API Changelog Changeset has been deprecated and Commit was added. Stash API Compatibility Policy states that deprecated classes and method should work until next major version release (which is 4.0).

@mdoninger how does your issue manifest exactly?

lpandzic commented 8 years ago

Nonetheless, thanks for the pull request. This will be required for the 4.0 release but for now it is a breaking change for users on older version.

mdoninger commented 8 years ago

After installing the plugin, we couldn't access the repository pages any more, everytime a 500 got thrown and in the logfile there were entries like "GET /rest/api/latest/profile/recent/repos HTTP/1.1" c.a.s.r.e.UnhandledExceptionMapper Unhandled exception while processin g REST call" Of course it can be totally unrelated to that plugin and maybe just an incompatibility between two plugins. I'm currently waiting, until our Stash admin installs my version on the Staging instance, then we will see.