search

infobloxopen / atlas-cli

Apache License 2.0
14 stars 45 forks source link

Template changes to add gateway response headers #12

Closed Evgeniy-L closed 6 years ago

Evgeniy-L commented 6 years ago

Test are failing because after dep init is called project is initialized linked to atlas-app-toolkit v0.5.0 and this version do not contain gateway.WithGatewayOptions. I narrowed down the problem but have not identified why this happens.

kumaya commented 6 years ago

somehow go-grpc-middleware version is creating this issue. v0.12.2: Could not introduce github.com/infobloxopen/atlas-app-toolkit@v0.12.2, as it has a dependency on github.com/grpc-ecosystem/go-grpc-middleware with constraint master, which has no overlap with existing constraint ^1.0.0 from (root)

Still need to figure out why @Evgeniy-L

Evgeniy-L commented 6 years ago

I've investigated this at it looks like a bug in dep. I created an issue for that. For now I propose to comment request ID interceptor and track this problem separately.

chinmayb commented 6 years ago

Will moving request ID interceptor to go.grpc.middleware solve the issue with dep ?

Evgeniy-L commented 6 years ago

@chinmayb, no, moving it to go.grpc.middleware will not solve the problem. Also we cannot reference anything from go.grpc.middleware in atlas-cli as it is not public.

Using github.com/grpc-ecosystem/go-grpc-middleware@1.0.0 in atlas-app-toolkit and in other places should solve the problem. But the problem in dep remains. Ideally after dep init the Gopkg.toml file should be resolved in a following way:

[[constraint]]
  branch = "master"
  name = "github.com/grpc-ecosystem/go-grpc-middleware"

[[constraint]]
  name = "github.com/infobloxopen/atlas-app-toolkit"
  version = "0.12.2"

instead of:

[[constraint]]
  name = "github.com/grpc-ecosystem/go-grpc-middleware"
  version = "1.0.0"

[[constraint]]
  name = "github.com/infobloxopen/atlas-app-toolkit"
  version = "0.5.0"