search

infobloxopen / atlas-cli

Apache License 2.0
14 stars 45 forks source link

Support go modules instead of dep for package management #38

Closed mlbloxer closed 4 years ago

mlbloxer commented 4 years ago

Would be great to have go modules OOB instead of dep. Please be aware that, @kd7lxl and I found out that in some scenarios, we are seeing

[atlas.log.collector] Running shell script
+ make fmt
go: github.com/Infoblox-CTO/atlas.ophidauth.middleware@v0.0.0-20190408190152-58fc2fc057da: invalid version: git fetch -f origin refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /home/ubuntu/workspace/TO_atlas.log.collector_PR-4-5G2BA45OWJUUZLL6DTOAOYBTN7W45TQJ4SEECAOTP7V6MTYQWR3A/pkg/mod/cache/vcs/9a3fcdf7744bc56b2631e58484cb8416d1983033bab18fd28f53ac1feaf1d09d: exit status 128:
    fatal: could not read Username for 'https://github.com': terminal prompts disabled
go: github.com/Infoblox-CTO/atlas.ophidauth.middleware@v0.0.0-20190408190152-58fc2fc057da: invalid version: git fetch -f https://github.com/Infoblox-CTO/atlas.ophidauth.middleware refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /home/ubuntu/workspace/TO_atlas.log.collector_PR-4-5G2BA45OWJUUZLL6DTOAOYBTN7W45TQJ4SEECAOTP7V6MTYQWR3A/pkg/mod/cache/vcs/9a3fcdf7744bc56b2631e58484cb8416d1983033bab18fd28f53ac1feaf1d09d: exit status 128:
    fatal: could not read Username for 'https://github.com': terminal prompts disabled
Makefile.common:50: recipe for target 'fmt-atlas' failed
make: *** [fmt-atlas] Error 1

Tom has this PR to temporary workaround https://github.com/Infoblox-CTO/atlas.log.collector/pull/6#partial-pull-merging

seizadi commented 4 years ago

You can close this when the following PR is merged. https://github.com/infobloxopen/atlas-cli/pull/59 and we create a new release tag for atlas-cli

seizadi commented 4 years ago

Fixed with https://github.com/infobloxopen/atlas-cli/releases/tag/v0.4.0