search

infobloxopen / atlas-cli

Apache License 2.0
14 stars 45 forks source link

Fix problem with expand option #59

Closed seizadi closed 4 years ago

seizadi commented 4 years ago

The expand option was broken, it did not use go-bindata package and also the paths were broken when you used go-bindata. I think it was tested in a development environment where all template files were available and when run in a standalone binary would break.

In the process of fixing and building a new binary found that there was regression and Resolving imports... stage broke with EOF exception in the templates.Process()

 withImports, err := imports.Process(path, nil, nil)

I fixed this by upgrading from 2018 era packages to current so the tools package is now golang.org/x/tools v0.0.0-20200528185414-6be401e3f76e

I switched the project to use Go Module.

drewwells commented 4 years ago

Is this code being built during Ci, so this issue gets caught next time?