Previously, atlas-cli was generating a Jenkinsfile that did cleanup in the always block. This can be problematic when there are multiple post conditions. always is always the first post-condition to run. If always cleans up the artifacts before success has a chance to process them, the pipeline will fail. By appropriately using the cleanup block, the cleanup will run after all other operations.
Jenkins specifies that cleanup should be done in the
cleanupblock: https://www.jenkins.io/doc/book/pipeline/syntax/#postPreviously,
atlas-cliwas generating a Jenkinsfile that did cleanup in thealwaysblock. This can be problematic when there are multiplepostconditions.alwaysis always the first post-condition to run. Ifalwayscleans up the artifacts beforesuccesshas a chance to process them, the pipeline will fail. By appropriately using thecleanupblock, the cleanup will run after all other operations.