search

infobloxopen / infoblox-ansible

Ansible modules for interfacing to Infoblox systems
GNU General Public License v3.0
54 stars 60 forks source link

Fix the 1.4.0 major changes changelog #159

Closed samccann closed 1 year ago

samccann commented 1 year ago

This line is breaking the Ansible porting guide CI. It is seeing the first and assuming this is a bold syntax and the ending is missing. Adding backticks around this so the ansible/ansible CI understands the sentence.

This PR is required for Ansible 7 and will thus mean I think that this collection needs to spin a new release as soon as possible.

rooftopcellist commented 1 year ago

@hemanthKa677 could you give this a review when you get a chance? We ran into this when generating the porting guide for the Ansible Community release.

Thanks!

felixfontein commented 1 year ago

Actually the changelog has a couple of errors. When you run the linter antsibull-changelog lint-changelog-yaml changelogs/changelog.yaml you can see:

changelogs/changelog.yaml:0:0: 'releases' -> '1.1.1' -> 'changes': section "release_summary" must be type str not list
changelogs/changelog.yaml:0:0: 'releases' -> '1.1.2' -> 'changes': section "release_summary" must be type str not list
changelogs/changelog.yaml:0:0: 'releases' -> '1.2.0' -> 'changes': section "release_summary" must be type str not list
changelogs/changelog.yaml:0:0: 'releases' -> '1.2.2' -> 'changes': section "release_summary" must be type str not list
changelogs/changelog.yaml:0:0: 'releases' -> '1.3.0' -> 'changes': invalid section: bug_fixes
changelogs/changelog.yaml:0:0: 'releases' -> '1.3.0' -> 'changes': section "release_summary" must be type str not list
changelogs/changelog.yaml:0:0: 'releases' -> '1.4.0' -> 'changes': (WARNING/2) Inline emphasis start-string without end-string.
changelogs/changelog.yaml:0:0: 'releases' -> '1.4.0' -> 'changes': section "release_summary" must be type str not list

The second to last entry is the one fixed by this PR.

@hemanthKa677 since you don't seem to work with changelog fragments (which would get linted by ansible-test sanity), please make sure that you run antsibull-changelog lint-changelog-yaml directly on the cangelogs/changleog.yaml file to avoid such problems! It should be pretty easy to add something to GHA to check this.

Andersson007 commented 1 year ago

cc @Vaishnavi-infoblox @anagha-infoblox

rooftopcellist commented 1 year ago

@hemanthKa677 I do not have the permissions to merge this PR, do you? Also, as @felixfontein mentioned, there are some other issues which need to be fixed. Is that something someone on the Infoflox team can look in to?

Thanks!

samccann commented 1 year ago

Hi folks - do we have a timeline on when this will merge and a new collection version created? If a new collection is not created by Monday (Nov 7), we will break the release of the Ansible 7 beta and have to manually patch around this again.

samccann commented 1 year ago

@hemanthKa677 sorry that's beyond my capabilities as a docs person. I looked but I can't determine what's failing.

felixfontein commented 1 year ago

@hemanthKa677 you should really call ansible-test units with --docker, then you don't have to worry about such strange failures. Running it without --docker requires more specific versions of tools like pylint.

samccann commented 1 year ago

Thanks!

samccann commented 1 year ago

@hemanthKa677 - We still need an updated release of this collection. This error broke the Ansible 7 release of docs today. We patched around it for now but can you please release an update to this collection on Galaxy so we won't hit this again?

felixfontein commented 1 year ago

Please also note https://github.com/ansible-collections/overview/blob/main/removal_from_ansible.rst#collections-not-satisfying-the-collection-requirements.