Updated connector's urlencoding logic for proper array encoding - Githubissues

infobloxopen / infoblox-client

Infoblox NIOS Python WAPI Client

Apache License 2.0

142 stars 104 forks source link

Updated connector's urlencoding logic for proper array encoding #287

Closed achernevskii closed 3 years ago

achernevskii commented 3 years ago

Issue Description

The client was unable to perform array-search, because query parameters containing array was URL-encoded like this:	Parameter	URL-Encoding
`{'array_option': ['value1', 'value2']}`	`...?array_option=%5B%27value1%27%2C+%27value2%27%5D`

Instead, every entry in an array should be URL-encoded as a separate key/value pair. Like this:	Parameter	URL-Encoding
`{'array_option': ['value1', 'value2']}`	`...?array_option=value1&array_option=value2`

How It Was Fixed

Added doseq=True parameter to Connector's _urlencode method call.
Now arrays in query params will be URL-encoded as a set of key/value pairs. Each key/value will represent an entry in the respective array.
This will make array-search possible.
Closes #280.

Unit Tests

test_construct_url_with_query_params_containing_array -- checks if Connector's _construct_url method encodes array as it was described earlier.

Reviewers

@anagha-infoblox, @somashekhar

achernevskii commented 3 years ago

@anagha-infoblox, @somashekhar please take a look.