search

infobyte / faraday

Open Source Vulnerability Management Platform
https://www.faradaysec.com
GNU General Public License v3.0
4.78k stars 885 forks source link

Vulnerability description field is being stripped from newlines when creating CSV file. Make that an option! #409

Closed gister9000 closed 3 years ago

gister9000 commented 3 years ago

Issue Type

Not sure if it's a bug or intentional. Likely intentional.

Faraday version

Release v3.11

Steps to reproduce

  1. Write/import a nice vuln description like this one: image

  2. Download CSV and see that newlines were stripped: image

Expected results

I expected to find "\n" characters where newlines were in the description.

Why don't you allow users to configure whether or not they want their newlines to be stripped or not? I think that most users like to preserve the newline they entered since they entered it for a reason.

gister9000 commented 3 years ago

Do you want me to contribute by changing this myself? BTW, why can't I edit references after creating the vulnerability? Should I change that as well?

EricHorvat commented 3 years ago

Hi @gister9000 !

We will see this an issue, and problaby fixed in the next release. But we're open to community PRs! So if you fix this before us, surely would be merged!

Best regards

Horvat Eric

llazzaro commented 3 years ago

Hi @gister9000,

why can't I edit references after creating the vulnerability?

Yes, you need to select the vuln and then click on the edit button.

gister9000 commented 3 years ago

Hi @EricHorvat, thanks for acknowledging the issue. I will probably wait for the next release though :D

Hi @llazzaro, thanks! I was clicking the vulnerability and not the edit button. That solves it!

Best regards, Filip Jelić

aenima-x commented 3 years ago

@gister9000 This will be fixed in the next release (3.15)