infobyte / faraday

Open Source Vulnerability Management Platform
https://www.faradaysec.com
GNU General Public License v3.0
5.06k stars 917 forks source link

Remove a logical test that is always true #463

Open openrefactory opened 1 year ago

openrefactory commented 1 year ago

In file: get_exploits.py, method: get_exploits, a logical expression uses the identity operator. A new object is created inside the identity check operation and then used for matching identity. Since this is a distinct, new object, it will not have identity an match with anything else. As a result, the identity check will have a logical short circuit and the program may have unintended behavior. I suggested that the logical operation should be reviewed for correctness.