Open kornypoet opened 13 years ago
There has been some discussion of splitting the game_stats into two different API calls. The first being pretty general, the second being the innings and play-by-play. I will post more as the discussion develops.
@vaniver
home_stadium can change from season to season. In the team_record, we only want the location of the last season's home stadium, without any information on what the stadium was previously called?
Yeah, there was some issues with this, but I felt that the year by year record was getting too big, so I pulled all of the information back to the top level. What there needs to be is a note in the documentation saying that the colors, leagues, divisions, and stadiums are all from current data, and that the changing data will still be reflected in the season API.
If we're pulling the game_id out of the season_record object, are we also pulling it out of the season_stats_catalog_entry description?
Yeah, there might need to be a little description cleanup for each of the Icss.
The pitching player stats are broken. I've checked all of the game files and none of them have a battersFaced that isn't 0. Should we drop all four int fields from the pitcher record?
Are all of the start times in the season xmls PM EST times?
That sucks about the pitching stats. Keep it in there for now, but I will raise the issue. You can double check the time zone by comparing the start time to espn's official start times(which are in EST).
The times appear to be local start times. My current solution is to just turn "207" into "2:07 PM"; prefer something else?
Clarification: the league and division ranks stored in the game_stat_record should be as of the date of that game, not the final ranking for that year. [Y/n]
Yes to the time question, if you can't determine the time zone, just drop it. The game_stat_record should have the rankings as of that date, and the season_stat_record should have the final(latest) ranking for the season. The dates seem to line up perfectly in the rankings files.
Well, it would be possible to have a hash of locations to time zones and figure out what to report the time as, but I'd much rather drop it.
The dates are almost perfect- postseason games aren't included. I just used the last season rankings. The engine is almost finished, and going through final testing now.