search

infoderm / patients

:face_with_thermometer: Patients meteor app
GNU Affero General Public License v3.0
5 stars 2 forks source link

Optimize `Dockerfile` layering #867

Closed make-github-pseudonymous-again closed 5 months ago

make-github-pseudonymous-again commented 5 months ago

Copy necessary files step by step:

  1. Install meteor
  2. Install meteor packages
  3. Install package.json dependencies
  4. Build from sources
make-github-pseudonymous-again commented 5 months ago

Could also base final container image on scratch.

make-github-pseudonymous-again commented 5 months ago

From scratch is too much hassle to setup. distroless is an acceptable alternative.

make-github-pseudonymous-again commented 5 months ago

Since both #868 and #869 are merged, we can close here.

make-github-pseudonymous-again commented 5 months ago

Note that the choice for distroless was mainly derived from https://snyk.io/blog/choosing-the-best-node-js-docker-image/.