infoderm / patients

:face_with_thermometer: Patients meteor app
GNU Affero General Public License v3.0
5 stars 2 forks source link

Configure `restore-keys` for puppeteer cache in `ci:test` #975

Closed make-github-pseudonymous-again closed 1 month ago

make-github-pseudonymous-again commented 1 month ago

This fixes #865 for good.

Since meteor-actions/install now can skip the installation of cached packages using restore keys, it can happen that node_modules/puppeteer is restored from cache while its chromium download is not.

With this commit, we ensure that the weakest restore key for chromium is at least as weak as the weakest restore key for node_modules/puppeteer.

Maybe an alternative would be to instruct puppeteer to install chromium under node_modules? But for now, this is good enough.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.86%. Comparing base (6308ea8) to head (30a1651). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #975 +/- ## ========================================== - Coverage 65.88% 65.86% -0.03% ========================================== Files 715 715 Lines 9893 9893 Branches 1346 1346 ========================================== - Hits 6518 6516 -2 - Misses 2917 2919 +2 Partials 458 458 ``` | [Flag](https://app.codecov.io/gh/infoderm/patients/pull/975/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=infoderm) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/infoderm/patients/pull/975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=infoderm) | `46.23% <ø> (-0.03%)` | :arrow_down: | | [server](https://app.codecov.io/gh/infoderm/patients/pull/975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=infoderm) | `61.87% <ø> (ø)` | | | [test](https://app.codecov.io/gh/infoderm/patients/pull/975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=infoderm) | `71.97% <ø> (ø)` | | | [test-app](https://app.codecov.io/gh/infoderm/patients/pull/975/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=infoderm) | `53.70% <ø> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=infoderm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.