search

infojunkie / musicxml-player

A TypeScript component that loads and plays MusicXML files in the browser using Web Audio and Web MIDI.
https://blog.karimratib.me/demos/musicxml/
GNU General Public License v3.0
34 stars 6 forks source link

Accept renderer objects passed into `Player.load` #1

Closed infojunkie closed 1 year ago

infojunkie commented 1 year ago

...instead of or in addition to the renderer enum that's currently used. This will allow the caller to perform special work on the renderer, such as pre-loading the MusicXML document, rendering to MIDI, etc.

Also make sure to allow the renderer to be passed an instance of the underlying engine.

infojunkie commented 1 year ago

On second thought - better to create a separate interface for MIDI rendering and keep the MusicXML rendering separate as it is now.