search

infolab-csail / wikithingsdb

A DB of Synonyms, Paraphrases, and Hypernyms for all Wiki Things (Articles)
3 stars 3 forks source link

Explains multiprocessing import #12

Closed michaelsilver closed 9 years ago

michaelsilver commented 9 years ago

Per @sfelshin's suggestion in #9, added a comment to setup.py to explain import multiprocessing.

Sue, if this looks good to you, just comment "looks good to me," and I'll merge the pull request.

sfelshin commented 9 years ago

When I view the change, I see

-- begin -- import multiprocessing +# import multiprocessing to prevent nose error when running tests: +# TypeError: 'NoneType' object is not callable -- end --

Is it correct python style to put comments below what they're commenting on? If so, looks good to me. If not, the comment should go above.

michaelsilver commented 9 years ago

Moved comment to above import in df6adb6, since this is technically the general python style, although it is rare (as far as I have seen) to use comments in imports.