search

infolab-csail / wikithingsdb

A DB of Synonyms, Paraphrases, and Hypernyms for all Wiki Things (Articles)
3 stars 3 forks source link

Migrate to peewee #22

Closed alvaromorales closed 8 years ago

alvaromorales commented 8 years ago

Moved from SQLAlchemy+MySQL to peewee+PostgreSQL.

Renamed fetch to query for consistency. "query" is more natural when dealing with a DB system. Also, this avoids confusion with the WikipediaBase fetcher, in charge of scraping HTML pages.

Added util module for helper functions.

Switched to WikipediaBase-style classes. Because WikipediaBase is a long-standing production system, we should use its convention for Wikipedia classes. The convention is to prepend "wikipedia-" to class names, and use dashes instead of spaces. For backwards compatibility and flexibility, I made it such that you can specify both wikipedia classes (e.g. "wikipedia-french-commune") and strings ("french commune") to query methods. We might want to revisit this later on.

Added Travis file and script to insert and test fake data. Added coveragerc and connected to codecov.

Fixes #16

codecov-io commented 8 years ago

Current coverage is 92.30%

Branch #22 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found. Review entire Coverage Diff as of 8cf30c7

Powered by Codecov. Updated on successful CI builds.

michaelsilver commented 8 years ago

Awesome, thank you! Really loving the articles_with_multiple_types :+1: Please see my inline comments for details. In addition, could you please add the obligatory travis badge to the readme?

I think we can also get rid of scripts/merge_extracted.sh and scripts/partition.py.

alvaromorales commented 8 years ago

Great, I updated the PR with your suggestions.

michaelsilver commented 8 years ago

LGTM! :rocket: