search

infonl / info-techradar

Owner: Edgar. A static site generator for the INFO Technology Radar based on the AOE Tech Radar generator.
https://infonl.github.io/info-techradar/index.html
Other
2 stars 0 forks source link

Improve unfurling for better site previews of INFO Tech Radar #14

Open edgarvonk opened 1 year ago

edgarvonk commented 1 year ago

Our https://infonl.github.io/info-techradar/index.html does not show a nice preview in Slack (nor probably elsewhere).

See https://medium.com/slack-developer-blog/everything-you-ever-wanted-to-know-about-unfurling-but-were-afraid-to-ask-or-how-to-make-your-e64b4bb9254 for details on how to improve this.

Screenshot 2023-03-08 at 10 09 43

edgarvonk commented 1 year ago

Overriding the publlic/index.html file as per documentation does not work. The file just gets copied to /build but not processed at all. E.g. it ends up with content like

<link rel="stylesheet" href="%PUBLIC_URL%/fonts.css">

But also the JS links are not being added at all.

It seems this is due to: https://github.com/AOEpeople/aoe_technology_radar/issues/190 . Although it is closed I don't think it has been solved. Might be related to: https://github.com/AOEpeople/aoe_technology_radar/issues/327 as well (which they are working on).

snipem commented 1 year ago

https://github.com/AOEpeople/aoe_technology_radar/pull/371 may fix this