Open swuendri opened 2 years ago
Nice work! I'll have to take some time to look through more details. But I do have one piece of feedback/question:
Would it be possible/preferable include the builders in the @infor-up/m3-odin-angular
package? Instead of the separate @infor-up/m3-odin-angular-builders
package, I mean.
I'm guessing it would be handy to have the builders/schematics in the same place as the source, especially for handling ng add
, ng update
etc.
Dear @anhallbe,
my main idea was to distinguish between runtime and development package. The package m3-odin-angular
provides runtime services and in contrast the builder(s) are only necessary during development.
The reason of this PR isn't mainly to accept it. In my opinion it should be the base to discuss changes related to card https://github.com/infor-cloud/m3-h5-sdk/projects/3#card-37604863. Please give feedback that I can improve the code. With this builder I'm able to configure angular.json like:
And instead of calling
odin serve --multi-tenant --ion-api
I usenpx ng serve <project>
.