Is your feature request related to a problem? Please describe.
I'm developing inside a Docker container using the remote containers feature of vscode.
I can't complete the odin login though, since the browser window for authentication won't open. This is caused by the additional sandboxing that happens when launching a browser, which is not possible inside a Docker container.
However it can quite easily by solved by adding two additional flags to the Puppeteer launch command.
Describe the solution you'd like
It is possible to add the two flags --no-sandbox and --disable-setuid-sandbox to puppeteer.launch.
Either as environment variable, CLI parameter or part of the config, whatever fits best.
Additional context
Corresponding part of the code:
cli/src/commands/login.ts
Is your feature request related to a problem? Please describe. I'm developing inside a Docker container using the remote containers feature of vscode. I can't complete the
odin login
though, since the browser window for authentication won't open. This is caused by the additional sandboxing that happens when launching a browser, which is not possible inside a Docker container. However it can quite easily by solved by adding two additional flags to the Puppeteer launch command.Describe the solution you'd like It is possible to add the two flags
--no-sandbox
and--disable-setuid-sandbox
topuppeteer.launch
. Either as environment variable, CLI parameter or part of the config, whatever fits best.Additional context Corresponding part of the code:
cli/src/commands/login.ts
I could imagine a solution like: