search

infor-cloud / m3-h5-sdk

https://infor-cloud.github.io/m3-h5-sdk/
34 stars 20 forks source link

Add tests to m3 odin #147

Closed swuendri closed 1 year ago

swuendri commented 1 year ago

Dear @anhallbe,

with this PR I want to introduce a lot of automatic unit and integrations tests for m3-odin.

There is one breaking change in function toMIFormat at runtime.ts file, because the functionality was wrong (in my opinion).

anhallbe commented 1 year ago

Looks very promising!

I'll hopefully get some time for a full review with feedback later this week.

One thing: The project is already set up with karma/jasmine (because Angular).

I would definitely prefer to use the same testing frameworks for the core project as well. Both for consistency and for keeping the number of dependencies down.

We could go so far as to set up infor-up/m3-odin as an Angular library project, complete with ng test, ng build etc for even more consistency. I've done something similar in other projects and it's been quite nice to work with. The only downside has been some APF shenanigans when Angular stopped producing UMD bundles. But I don't think that would be an issue here

swuendri commented 1 year ago

My changes are done @anhallbe. m3-odin is now an Angular library with jasmine/karma unit tests.