infor-design / enterprise-ng

Angular wrappers for IDS Enterprise components
Apache License 2.0
55 stars 82 forks source link

RTL Dropdown: Dropdown icon and list shifts upon opening #1640

Open kyfloresca opened 5 months ago

kyfloresca commented 5 months ago

Describe the bug On RTL, dropdown list moves down and icon moves to the left.

To Reproduce

  1. Change to RTL
  2. Click on any dropdown
  3. Open dropdown

Expected behavior The dropdown icon and list should not move.

Version

Screenshots image

Recording: https://github.com/infor-design/enterprise-ng/assets/116287798/e425c3bd-bc8a-43dc-95c6-86eca80162c6

Platform

Additional context Issue seen in Infor M3.

tmcconechy commented 5 months ago

@kyfloresca i think this is duplicate of https://github.com/infor-design/enterprise/pull/8455 Issue: https://github.com/infor-design/enterprise/issues/8305

Seem like the same thing?

kyfloresca commented 5 months ago

@tmcconechy , yep its the same with https://github.com/infor-design/enterprise/pull/8455.

i was double checking the ltr view and i found that the dropdown list also moves slightly down: image

chrome setting: zoom level 125%

is this also handled in https://github.com/infor-design/enterprise/pull/8455? thanks!

tmcconechy commented 5 months ago

@kyfloresca I think it looks ok on zoom to me on a quick test (has to be closed when you zoom). You can test it yourself as the Pull request posts a link

https://8305-rtl-dropdown-select-enterprise.demo.design.infor.com/components/multiselect/example-index.html?locale=ar-SA

So just have a test, if you see additional points make a comment on https://github.com/infor-design/enterprise/pull/8455 since its still an active pull request