search

infor-design / enterprise-ng

Angular wrappers for IDS Enterprise components
Apache License 2.0
55 stars 81 forks source link

Datagrid: Nested datagrid disappears after render #1656

Closed dmcodrum closed 4 days ago

dmcodrum commented 2 months ago

Describe the bug Expanded/nested datagrid not working after upgrade from IDS NG 16 to 17.

I am unable to recreate this in test or stackflow environment with a simple example but Tim is aware of the details of this issue.

To Reproduce Steps to reproduce the behavior:

  1. In our application (GLT), open a 'Material Content Report'
  2. In the datagrid click one of the expanders.
  3. The nested inside datagrid appears for a brief moment and then disappears. There is still an empty space where the inside grid should still be showing.

Expected behavior The inside grid should remain visible

Version

Platform

Additional context In discussion with Tim , we believe that this bug may be caused by these fixes: https://github.com/infor-design/enterprise/pull/8070/files and/or https://github.com/infor-design/enterprise-ng/pull/1464/files In our application the nested datagrid is an Angular component.

AAlviar commented 2 months ago

Hi @dmcodrum - Please provide an environment for to reproduce this issue. We will reach out separately for the credentials.

dmcodrum commented 2 months ago

I'll let you know when I have something setup. Thanks!

On Wed, Mar 27, 2024 at 8:42 AM AAlviar @.***> wrote:

Hi @dmcodrum https://github.com/dmcodrum - Please provide an environment for to reproduce this issue. We will reach out separately for the credentials.

— Reply to this email directly, view it on GitHub https://github.com/infor-design/enterprise-ng/issues/1656#issuecomment-2022673427, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJLVVFU3F77VNPIUW36YPPLY2K5D3AVCNFSM6AAAAABE6DV6Z6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRSGY3TGNBSG4 . You are receiving this because you were mentioned.Message ID: @.***>

tjamesallen15 commented 1 month ago

Where's the test page for this one? @AAlviar

tmcconechy commented 4 weeks ago

This one is complicated @tjamesallen15 you will have to look at some setup that @dmcodrum provides and try and debug it and see if you can figure out the issue.

cc @AAlviar

Maybe the fix might be something like making sure https://github.com/infor-design/enterprise/pull/8070/files#diff-13c32b0c73b40992aa6d376fb22d6746845a3b7d6d2545e19bd30687bcabb5a5R4417 only fires once per render for expandable areas..

dmcodrum commented 4 weeks ago

@tjamesallen15 - like Tim said, this is a difficult one to create a test case for. My idea is for us to have a Teams call so I can show you the issue. Likewise, you can run/debug in a remote session on my machine. Please schedule a call to discuss to fit your availability. You can see my calendar on outlook - daniel.mcodrum@infor.com. I'm EST. Thanks!

tjamesallen15 commented 3 weeks ago

@tjamesallen15 - like Tim said, this is a difficult one to create a test case for. My idea is for us to have a Teams call so I can show you the issue. Likewise, you can run/debug in a remote session on my machine. Please schedule a call to discuss to fit your availability. You can see my calendar on outlook - daniel.mcodrum@infor.com. I'm EST. Thanks!

I messaged you on teams so that we can test about this topic.

tjamesallen15 commented 3 weeks ago

Update:

@dmcodrum and I checked up the bug and I have an initial code change for this one. I will just test this on our code base to see if any will issue will arise.

cc @tmcconechy @ericangeles

tjamesallen15 commented 1 week ago

Made a PR for this one, cross tested with @dmcodrum via call