infor-design / enterprise-ng

Angular wrappers for IDS Enterprise components
Apache License 2.0
57 stars 83 forks source link

ModuleNav: Default Icon on Module-Nav Switcher doesn't align with the rest of icons #1663

Open Abrai7 opened 6 months ago

Abrai7 commented 6 months ago

Describe the bug On the module-nav switcher if no icon is provided using the [icon] property then a "Em" icon is displayed.

image

However, this default icon size is 32x32, which doesn't align with the rest of icons (18x18).

To Reproduce Steps to reproduce the behavior:

  1. Go to https://stackblitz.com/edit/ids-quick-start-1711-jtxbae?file=src%2Fapp%2Fapp.component.html
  2. Leave property [icon] as empty. Expected behavior Is there a way to leave control/set up the size of that icon to 32x32? Is the default icon hardcoded?

Version

Screenshots

image image

Platform

Additional context Issue can also be observed in: https://design.infor.com/components/components/module-nav/enterprise/

tmcconechy commented 6 months ago

Does seem like a bug. I think we have a default string in there hard coded. But i think you want to set it like these examples:

https://main-enterprise.demo.design.infor.com/components/module-nav/example-icon.html https://main-enterprise.demo.design.infor.com/components/module-nav/example.html

Abrai7 commented 6 months ago

@tmcconechy Normally I set it with a string, like this:

image

but doing it this way won't expand the icon to use the full size of the button.

tmcconechy commented 4 months ago

@Abrai7 I misread this before but we checked this on https://main-enterprise.demo.design.infor.com/components/module-nav/example-icon.html and think everything is working as intended.

It is showing the default icon and it is 32x32. This is the correct design and size for the icons in that location. They should not be 18x18.

Is there anything we are missing here given the design is correct?

ericangeles commented 3 days ago

@Abrai7, could you confirm if this is still an issue in the latest version of IDS?