infor-design / enterprise-ng

Angular wrappers for IDS Enterprise components
Apache License 2.0
57 stars 84 forks source link

SohoTabsComponent: Odd behaviour with the "overflow dropdown" #1730

Open madebyannalam opened 2 months ago

madebyannalam commented 2 months ago

Describe the bug The following issues have been observed when one has enough tabs in a SohoTabsComponent to trigger the "overflow dropdown":

To Reproduce Steps to reproduce the behavior:

  1. Have a SohoTabsComponent with around 7-8 tabs.
  2. Minimise the browser window to a size where the "overflow dropdown" will appear.
  3. Select any tab from that dropdown.
  4. Take note of the change in tab width and the tab component not activating the selected tab.

Expected behavior

Version

Screenshots image image image image

Platform

Additional context N/A

tmcconechy commented 2 months ago

@madebyannalam would it be possible to add an example to make this more clear https://stackblitz.com/edit/ids-quick-start-1781?file=src%2Fapp%2Fapp.component.ts

One thing that might help is you can now set the tab width (in newer versions i think 17.6.2 but possibly a little newer) explore equalWidth and or maxWidth

https://github.com/infor-design/enterprise/blob/main/src/components/tabs/tabs.js#L67-L71

tmcconechy commented 2 months ago

also i think a bug was fixed where the tab is not activated. On the latest version try this:

  1. go to https://main-enterprise.demo.design.infor.com/components/tabs/example-index.html
  2. resize the page so an overflow occurs
  3. open the menu and pick the last tab

Is that the bug your ultimately describing? if so might just need an update

madebyannalam commented 2 months ago

also i think a bug was fixed where the tab is not activated. On the latest version try this:

  1. go to https://main-enterprise.demo.design.infor.com/components/tabs/example-index.html
  2. resize the page so an overflow occurs
  3. open the menu and pick the last tab

Is that the bug your ultimately describing? if so might just need an update

That was one of the issues. I'll send word to MRM's Business Analysts check it next time we update our Soho version.

madebyannalam commented 2 months ago

@madebyannalam would it be possible to add an example to make this more clear https://stackblitz.com/edit/ids-quick-start-1781?file=src%2Fapp%2Fapp.component.ts

One thing that might help is you can now set the tab width (in newer versions i think 17.6.2 but possibly a little newer) explore equalWidth and or maxWidth

https://github.com/infor-design/enterprise/blob/main/src/components/tabs/tabs.js#L67-L71

I haven't been able to reproduce my other issue with the supplied stackblitz. While the equalWidth setting does sound like it will tick most of our boxes, I can't access it in MRM's current implementation of SoHo (we're on version 17.6.2 of ids-enterprise-ng).