infor-design / enterprise-ng

Angular wrappers for IDS Enterprise components
Apache License 2.0
58 stars 83 forks source link

Upgrade to @angular/cli and @angular 7.2 #327

Closed bthharper closed 5 years ago

bthharper commented 5 years ago

Describe the bug

Targeting an application to use ids-enterprise-ng and angular/cli 7.2.x fails with the error:

ERROR in node_modules/ids-enterprise-ng/lib/utils/deprecated-event-emitter.d.ts(6,5): error TS2416: Property 'subscribe' in type 'DeprecatedEventEmitter<T>' is not assignable to the same property in base type 'EventEmitter<T>'.
  Type '(generatorOrNext?: any, error?: any, complete?: any) => void' is not assignable to type '(generatorOrNext?: any, error?: any, complete?: any) => Subscription'.
    Type 'void' is not assignable to type 'Subscription'.

This looks to be caused by the use of typescript 3.2.2 which is stricter on type declarations.

To Reproduce

Checkout id-enterprise-quickstart-ng

npm i
npm i @angular/cli@latest
ng upgrade @angular/cli @angular/core
ng s

Expected behavior

The application should compile and run.

Version

Screenshots

N/A

Platform

Additional context Add any other context about the problem here.

tmcconechy commented 5 years ago

This was added and merged.