infor-design / enterprise-ng

Angular wrappers for IDS Enterprise components
Apache License 2.0
57 stars 83 forks source link

'filterConditions' does not exist in type 'SohoDataGridColumn' #350

Closed kvchaudhari closed 5 years ago

kvchaudhari commented 5 years ago

Describe the bug In SohoGridColumn on column we have added filter conditions like 1filterConditions:['equals','contains'] For Angular4 version this was consider as warning. Now we are upgrading Angular4 to Angular7 . For Angular7 build is getting failed and getting error like"Object literal may only specify known properties, and 'filterConditions' does not exist in type 'SohoDataGridColumn'. "`

To Reproduce Steps to reproduce the behavior:

 columnsAPPInstanceList: SohoDataGridColumn[] = [
    {
      id: 'app_name', name: 'AppName', field: 'applicationName', filterType: 'text',  filterConditions: ['equals', 'contains']
    }
  1. See error Object literal may only specify known properties, and 'filterConditions' does not exist in type 'SohoDataGridColumn

Expected behavior It should be allowed to take "filterConditions" in SohoDataGridColumn

Version

Screenshots If applicable, add screenshots to help explain your problem. imgo

Platform

Additional context Add any other context about the problem here.

tmcconechy commented 5 years ago

Just need to add the types and do a pull request 👍

tmcconechy commented 5 years ago

Pushed a fix for this onto master. This will be now in 5.10.0