infor-design / enterprise-wc

Enterprise-grade web component library for the Infor Design System
Apache License 2.0
27 stars 26 forks source link

IdsLoadingIndicator: Design Enhancements and new Features #201

Closed tmcconechy closed 2 years ago

tmcconechy commented 3 years ago

Based on the design at https://www.figma.com/file/PwwLkUtTxpxLzRJzm5kACM/IDS-Progress-Indicators?node-id=0%3A1 we want to build out some of the elements and port some of it as noted. See https://material.io/components/progress-indicators#usage for inspiration

We want to also port the design changes back to 4.x . I.E. whats "design changed" and the line loader styles (phase 1 items).

Loader (Phase 1)

Line Loader (Phase 1)

Spinners (Phase 1)

Other Tasks (Phase 1)

Progress Buttons (Future)

Skeleton (Future)

Suggested Internal Markup

<ids-loading-indicator percent="10" type="circular" determinate="true"></ids-loading-indicator>
<!-- Centered in the Card -->
<ids-loading-indicator type="linear"></ids-loading-indicator>
<ids-loading-indicator type="circular"></ids-loading-indicator>
<!-- Top Page Loader on a Card or Page/Container or Datagrid-->
<ids-loading-indicator type="bar"></ids-loading-indicator>

<!-- Future -->
<ids-loader type="skeleton"></ids-loader>

or Loader:

Suggested Dependencies NA

Settings

Design

Events

Other Pass the following checklist ordered in priority (some may be left for later) https://github.com/infor-design/enterprise-wc/blob/main/doc/CHECKLIST.md

rob2d commented 3 years ago

Thinking on it a little while trying to create example markup, I have a few ideas for possible iteration:

(1) type

which seems to be concise on what bar was is doing with it

(2) setting for determinate

Examples:

circular indeterminate

<ids-loading-indicator></ids-loading-indicator>

determinate and representing full view

<ids-loading-indicator progress="10" affixed></ids-loading-indicator>

indeterminate and linear

<ids-loading-indicator linear></ids-loading-indicator>
tmcconechy commented 3 years ago

I like that but the only one im not sure about is:

Will get the copy team involved on https://jira.infor.com/browse/UXD-2617?focusedCommentId=8344423&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-8344423 so will try and setup something to discuss between the ideas.

rob2d commented 3 years ago

For type it just seemed that affixed is just a variant for a linear loader; only contrasted by their position and a difference of about 2 pixels (so, both are actually "linear" in a sense). That and the implicit "type" (e.g. type needs double value) if not specified.

rob2d commented 3 years ago

Just for ref on the issue: for the WC, this issue is technically in "review" and almost done there.

Need to go back to wrapping up the enterprise version which is started but it seemed a bit difficult to come up with efficient patterns for the different types immediately due to my lack of experience with it and also the context of the existing busy-indicator and inputs being slightly different there.

Currently on ids-splitter to be able to better time-box the sprint since it seems that one could get interesting, and will try to get back to this one intermittently next week.

tmcconechy commented 2 years ago

Duplicate of https://github.com/infor-design/enterprise/issues/5427