Closed tmcconechy closed 2 years ago
Thinking on it a little while trying to create example markup, I have a few ideas for possible iteration:
(1) type
ids-loading-indicator
(3), it could be easier for users to use a flag vs type -- which could be similar to how ids-pager-button
works in the recent PR (can still have a readonly type
as well). Saw elsewhere in repo.circular
and also 2/3 are basically just variants of linear, the default could be circular
?bar
variant/type
, it seems that actually linear is pretty similar, especially with ids-progress-bar
also being-bar-like and representing something that's a little more concrete for the app. Maybe we can use the word affixed
for a flag? def for the word "affix" is
to stick, attach, or fasten (something) to something else.
which seems to be concise on what bar
was is doing with it
(2) setting for determinate
determinate
, we could have progress
to indicate the percentage complete.
(@tmcconechy something we agreed about earlier and agreed on functionally but I realized maybe this could be the word we are looking for? I'm not certain on it just felt a little bit more natural than what we were at)Examples:
circular indeterminate
<ids-loading-indicator></ids-loading-indicator>
determinate and representing full view
<ids-loading-indicator progress="10" affixed></ids-loading-indicator>
indeterminate and linear
<ids-loading-indicator linear></ids-loading-indicator>
I like that but the only one im not sure about is:
Will get the copy team involved on https://jira.infor.com/browse/UXD-2617?focusedCommentId=8344423&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-8344423 so will try and setup something to discuss between the ideas.
For type it just seemed that affixed is just a variant for a linear loader; only contrasted by their position and a difference of about 2 pixels (so, both are actually "linear" in a sense). That and the implicit "type" (e.g. type needs double value) if not specified.
Just for ref on the issue: for the WC, this issue is technically in "review" and almost done there.
Need to go back to wrapping up the enterprise
version which is started but it seemed a bit difficult to come up with efficient patterns for the different types immediately due to my lack of experience with it and also the context of the existing busy-indicator and inputs being slightly different there.
Currently on ids-splitter
to be able to better time-box the sprint since it seems that one could get interesting, and will try to get back to this one intermittently next week.
Based on the design at https://www.figma.com/file/PwwLkUtTxpxLzRJzm5kACM/IDS-Progress-Indicators?node-id=0%3A1 we want to build out some of the elements and port some of it as noted. See https://material.io/components/progress-indicators#usage for inspiration
We want to also port the design changes back to 4.x . I.E. whats "design changed" and the line loader styles (phase 1 items).
Loader (Phase 1)
Line Loader (Phase 1)
Spinners (Phase 1)
Other Tasks (Phase 1)
ids-progress
toids-progress-bar
for clarityProgress Buttons (Future)
Skeleton (Future)
Suggested Internal Markup
or Loader:
Suggested Dependencies NA
Settings
Design
Events
Other Pass the following checklist ordered in priority (some may be left for later) https://github.com/infor-design/enterprise-wc/blob/main/doc/CHECKLIST.md